Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2485)

Unified Diff: chrome/browser/extensions/extension_management_test_util.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_test_util.cc
diff --git a/chrome/browser/extensions/extension_management_test_util.cc b/chrome/browser/extensions/extension_management_test_util.cc
index 3fcc0603e1323dc5fd7714bcec805d34d5bab078..b87364543791b1525284e634dd5e867458ff3984 100644
--- a/chrome/browser/extensions/extension_management_test_util.cc
+++ b/chrome/browser/extensions/extension_management_test_util.cc
@@ -7,6 +7,7 @@
#include <string>
#include <utility>
+#include "base/memory/ptr_util.h"
#include "components/crx_file/id_util.h"
#include "components/policy/core/common/configuration_policy_provider.h"
#include "components/policy/core/common/mock_configuration_policy_provider.h"
@@ -232,7 +233,8 @@ void ExtensionManagementPrefUpdaterBase::AddStringToList(
list_value = new base::ListValue();
pref_->Set(path, list_value);
}
- CHECK(list_value->AppendIfNotPresent(new base::StringValue(str)));
+ CHECK(
+ list_value->AppendIfNotPresent(base::MakeUnique<base::StringValue>(str)));
}
void ExtensionManagementPrefUpdaterBase::RemoveStringFromList(
« no previous file with comments | « chrome/browser/component_updater/supervised_user_whitelist_installer.cc ('k') | chrome/browser/extensions/extension_web_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698