chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc - Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/chooser_context_base.cc ('k') | chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

index 03bcef8310b046038be651ffc4a32342857442ee..4b3190b56537d63c21428e70c9ed0f590793525a 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

@@ -553,9 +553,9 @@ class ChromeLauncherControllerImplTest : public BrowserWithTestWindowTest {

void InsertPrefValue(base::ListValue* pref_value,

int index,

const std::string& extension_id) {

- base::DictionaryValue* entry = new base::DictionaryValue();

+ auto entry = base::MakeUnique<base::DictionaryValue>();

entry->SetString(ash::launcher::kPinnedAppsPrefAppIDPath, extension_id);

- pref_value->Insert(index, entry);

+ pref_value->Insert(index, std::move(entry));

}

void InsertRemoveAllPinsChange(syncer::SyncChangeList* list) {