Change more base::ListValue methods to use std::unique_ptr.

chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/accounts_options_handler.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/json/json_reader.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_metrics.h"
 #include "chrome/browser/ui/webui/chromeos/ui_account_tweaks.h"
 #include "chrome/grit/generated_resources.h"
@@ skipping 134 matching lines @@
     new_list->GetString(i, &whitelisted_user);
     if (gaia::ExtractDomainName(whitelisted_user) ==
         chromeos::login::kSupervisedUserDomain) {
       new_list->Remove(i, NULL);
       --i;
     }
   }
 
   const user_manager::UserList& users =
       user_manager::UserManager::Get()->GetUsers();
-  for (user_manager::UserList::const_iterator it = users.begin();
-       it < users.end();
-       ++it)
-    new_list->AppendIfNotPresent(new base::StringValue((*it)->email()));
+  for (const auto& user : users)

[danakj, 2016/09/14 01:55:59]

{}

also this is a pointer so const auto*?

[dcheng, 2016/09/14 03:06:11]

Done, I assumed it a std::unique_ptr but I guess I should have just checked!

+    new_list->AppendIfNotPresent(
+        base::MakeUnique<base::StringValue>(user->email()));
 
   if (OwnerSettingsServiceChromeOS* service =
           OwnerSettingsServiceChromeOS::FromWebUI(web_ui())) {
     service->Set(kAccountsPrefUsers, *new_list.get());
   }
 }
 
 }  // namespace options
 }  // namespace chromeos