Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: net/http/http_server_properties_manager.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/url_pattern_set.cc ('k') | net/http/http_server_properties_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_server_properties_manager.cc
diff --git a/net/http/http_server_properties_manager.cc b/net/http/http_server_properties_manager.cc
index 467c5b804545251f3a0dfde3271165d2be0c2e18..1f91bb691d9dafcf834710962d247e5188cd8ec3 100644
--- a/net/http/http_server_properties_manager.cc
+++ b/net/http/http_server_properties_manager.cc
@@ -7,6 +7,7 @@
#include <utility>
#include "base/bind.h"
+#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "base/single_thread_task_runner.h"
#include "base/stl_util.h"
@@ -1110,20 +1111,22 @@ void HttpServerPropertiesManager::UpdatePrefsOnPrefThread(
const url::SchemeHostPort server = map_it->first;
const ServerPref& server_pref = map_it->second;
- base::DictionaryValue* servers_dict = new base::DictionaryValue;
- base::DictionaryValue* server_pref_dict = new base::DictionaryValue;
+ auto servers_dict = base::MakeUnique<base::DictionaryValue>();
+ auto server_pref_dict = base::MakeUnique<base::DictionaryValue>();
// Save supports_spdy.
if (server_pref.supports_spdy)
server_pref_dict->SetBoolean(kSupportsSpdyKey, server_pref.supports_spdy);
- SaveSpdySettingsToServerPrefs(server_pref.settings_map, server_pref_dict);
+ SaveSpdySettingsToServerPrefs(server_pref.settings_map,
+ server_pref_dict.get());
SaveAlternativeServiceToServerPrefs(
- server_pref.alternative_service_info_vector, server_pref_dict);
+ server_pref.alternative_service_info_vector, server_pref_dict.get());
SaveNetworkStatsToServerPrefs(server_pref.server_network_stats,
- server_pref_dict);
+ server_pref_dict.get());
- servers_dict->SetWithoutPathExpansion(server.Serialize(), server_pref_dict);
- bool value = servers_list->AppendIfNotPresent(servers_dict);
+ servers_dict->SetWithoutPathExpansion(server.Serialize(),
+ std::move(server_pref_dict));
+ bool value = servers_list->AppendIfNotPresent(std::move(servers_dict));
DCHECK(value); // Should never happen.
}
« no previous file with comments | « extensions/common/url_pattern_set.cc ('k') | net/http/http_server_properties_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698