chrome/browser/chromeos/login/login_manager_test.cc - Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/login_manager_test.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/login_manager_test.cc

diff --git a/chrome/browser/chromeos/login/login_manager_test.cc b/chrome/browser/chromeos/login/login_manager_test.cc

index bd235d97a60043b0b5c58f13bca26da16693d1d3..6d807160ddee27be2f79f9eb025e3582c69615e2 100644

--- a/chrome/browser/chromeos/login/login_manager_test.cc

+++ b/chrome/browser/chromeos/login/login_manager_test.cc

@@ -155,7 +155,7 @@ void LoginManagerTest::SetUpOnMainThread() {

void LoginManagerTest::RegisterUser(const std::string& user_id) {

ListPrefUpdate users_pref(g_browser_process->local_state(), "LoggedInUsers");

- users_pref->AppendIfNotPresent(new base::StringValue(user_id));

+ users_pref->AppendIfNotPresent(base::MakeUnique<base::StringValue>(user_id));

}

void LoginManagerTest::SetExpectedCredentials(const UserContext& user_context) {