Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
index 98c2615154b20468bce0120f07a760dcadc27445..31a62cc287de196682e27d5291cf28bbb43e2feb 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
@@ -179,7 +179,8 @@ class DataReductionProxyCompressionStatsTest : public testing::Test {
base::ListValue* update = compression_stats_->GetList(pref);
update->Clear();
for (size_t i = 0; i < kNumDaysInHistory; ++i) {
- update->Insert(0, new base::StringValue(base::Int64ToString(0)));
+ update->Insert(
+ 0, base::MakeUnique<base::StringValue>(base::Int64ToString(0)));
}
}
@@ -549,7 +550,8 @@ TEST_F(DataReductionProxyCompressionStatsTest,
data_reduction_proxy::switches::kClearDataReductionProxyDataSavings);
base::ListValue list_value;
- list_value.Insert(0, new base::StringValue(base::Int64ToString(1234)));
+ list_value.Insert(
+ 0, base::MakeUnique<base::StringValue>(base::Int64ToString(1234)));
pref_service()->Set(prefs::kDailyHttpOriginalContentLength, list_value);
ResetCompressionStatsWithDelay(
@@ -563,7 +565,8 @@ TEST_F(DataReductionProxyCompressionStatsTest,
TEST_F(DataReductionProxyCompressionStatsTest,
ClearPrefsOnRestartDisabled) {
base::ListValue list_value;
- list_value.Insert(0, new base::StringValue(base::Int64ToString(1234)));
+ list_value.Insert(
+ 0, base::MakeUnique<base::StringValue>(base::Int64ToString(1234)));
pref_service()->Set(prefs::kDailyHttpOriginalContentLength, list_value);
ResetCompressionStatsWithDelay(

Powered by Google App Engine
This is Rietveld 408576698