chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc - Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc ('k') | chrome/browser/chromeos/policy/affiliation_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc

diff --git a/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc b/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc

index 0d19f8acd5dcdc7207507b90dd7657bcd8fbb1e0..51ebe0dfff6cf8a6a5b075b0e2b8c82056b03bc2 100644

--- a/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc

+++ b/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc

@@ -6,6 +6,7 @@

#include "base/files/file_path.h"

#include "base/files/file_util.h"

+#include "base/memory/ptr_util.h"

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

@@ -207,7 +208,8 @@ const user_manager::User* SupervisedUserManagerImpl::CreateUserRecord(

local_state,

kSupervisedUserManagerDisplayEmails);

- prefs_new_users_update->Insert(0, new base::StringValue(local_user_id));

+ prefs_new_users_update->Insert(

+ 0, base::MakeUnique<base::StringValue>(local_user_id));

sync_id_update->SetWithoutPathExpansion(local_user_id,

new base::StringValue(sync_user_id));