extensions: Change ScopedTempDir::path() to GetPath()

extensions: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=finnur@chromium.org
TBR=dgozman@chromium.org
BUG=640599
Committed: https://crrev.com/9142fe20179ba3b8efcc59138aa9e5ddd7aea449
Cr-Commit-Position: refs/heads/master@{#417268}

[vabr (Chromium), 2016-09-07 09:10:52]

Description was changed from

==========
//chrome/browser/extensions: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=finnur@chromium.org
BUG=640599
==========

to

==========
//[chrome/browser/]extensions: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=finnur@chromium.org
BUG=640599
==========

[vabr (Chromium), 2016-09-07 14:23:13]

Description was changed from

==========
//[chrome/browser/]extensions: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=finnur@chromium.org
BUG=640599
==========

to

==========
extensions: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=finnur@chromium.org
BUG=640599
==========

[vabr (Chromium), 2016-09-07 16:10:01]

vabr@chromium.org changed reviewers:
- finnur@chromium.org

[vabr (Chromium), 2016-09-07 16:10:14]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 16:10:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 17:20:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 17:20:38]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-09-07 19:12:19]

vabr@chromium.org changed reviewers:
+ finnur@chromium.org

[vabr (Chromium), 2016-09-07 19:13:23]

Hello Finnur,

Sorry to bother you twice today, but could you please review this whole CL? It
is big, but completely mechanical. And it is not urgent.

Thanks! :)

Vaclav

[vabr (Chromium), 2016-09-08 10:30:24]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 10:30:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-09-08 11:26:00]

LGTM, one nit.

https://codereview.chromium.org/2314363002/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/test_extension_dir.h (right):

https://codereview.chromium.org/2314363002/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/test_extension_dir.h:42: base::FilePath
unpacked_path() { return dir_.GetPath(); }
UnpackedPath, right?

[commit-bot: I haz the power, 2016-09-08 11:35:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 11:35:13]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-09-08 12:19:58]

Description was changed from

==========
extensions: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=finnur@chromium.org
BUG=640599
==========

to

==========
extensions: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=finnur@chromium.org
TBR=dgozman@chromium.org
BUG=640599
==========

[vabr (Chromium), 2016-09-08 12:21:13]

vabr@chromium.org changed reviewers:
+ dgozman@chromium.org

[vabr (Chromium), 2016-09-08 12:21:14]

Thanks!
Comment addressed.

Also, I'm adding dgozman@ as TBR for the mechanical change in
chrome/browser/devtools/devtools_sanity_browsertest.cc, which is a result of the
requested renaming of unpacked_path().

Cheers,
Vaclav

https://codereview.chromium.org/2314363002/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/test_extension_dir.h (right):

https://codereview.chromium.org/2314363002/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/test_extension_dir.h:42: base::FilePath
unpacked_path() { return dir_.GetPath(); }
On 2016/09/08 11:26:00, Finnur wrote:
> UnpackedPath, right?

Done.

[vabr (Chromium), 2016-09-08 12:21:26]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-09-08 12:21:27]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/2314363002/#ps130001
(title: "Comment addressed")

[commit-bot: I haz the power, 2016-09-08 12:21:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 13:19:45]

Description was changed from

==========
extensions: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=finnur@chromium.org
TBR=dgozman@chromium.org
BUG=640599
==========

to

==========
extensions: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=finnur@chromium.org
TBR=dgozman@chromium.org
BUG=640599
==========

[commit-bot: I haz the power, 2016-09-08 13:19:46]

Committed patchset #8 (id:130001)

[commit-bot: I haz the power, 2016-09-08 13:21:15]

Description was changed from

==========
extensions: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=finnur@chromium.org
TBR=dgozman@chromium.org
BUG=640599
==========

to

==========
extensions: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

R=finnur@chromium.org
TBR=dgozman@chromium.org
BUG=640599

Committed: https://crrev.com/9142fe20179ba3b8efcc59138aa9e5ddd7aea449
Cr-Commit-Position: refs/heads/master@{#417268}
==========

[commit-bot: I haz the power, 2016-09-08 13:21:17]

Patchset 8 (id:??) landed as
https://crrev.com/9142fe20179ba3b8efcc59138aa9e5ddd7aea449
Cr-Commit-Position: refs/heads/master@{#417268}