Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: chrome/browser/extensions/convert_web_app.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)
Patch Set: Comment addressed Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/convert_web_app.cc
diff --git a/chrome/browser/extensions/convert_web_app.cc b/chrome/browser/extensions/convert_web_app.cc
index 3c20a528a4d14c723cdde1bd19a344990715aee2..500f56974e003ee04e7f9963525bf170fe5d8105 100644
--- a/chrome/browser/extensions/convert_web_app.cc
+++ b/chrome/browser/extensions/convert_web_app.cc
@@ -136,7 +136,7 @@ scoped_refptr<Extension> ConvertWebAppToExtension(
}
// Write the manifest.
- base::FilePath manifest_path = temp_dir.path().Append(kManifestFilename);
+ base::FilePath manifest_path = temp_dir.GetPath().Append(kManifestFilename);
JSONFileValueSerializer serializer(manifest_path);
if (!serializer.Serialize(*root)) {
LOG(ERROR) << "Could not serialize manifest.";
@@ -144,7 +144,7 @@ scoped_refptr<Extension> ConvertWebAppToExtension(
}
// Write the icon files.
- base::FilePath icons_dir = temp_dir.path().AppendASCII(kIconsDirName);
+ base::FilePath icons_dir = temp_dir.GetPath().AppendASCII(kIconsDirName);
if (!base::CreateDirectory(icons_dir)) {
LOG(ERROR) << "Could not create icons directory.";
return NULL;
@@ -174,12 +174,9 @@ scoped_refptr<Extension> ConvertWebAppToExtension(
// Finally, create the extension object to represent the unpacked directory.
std::string error;
- scoped_refptr<Extension> extension = Extension::Create(
- temp_dir.path(),
- Manifest::INTERNAL,
- *root,
- Extension::FROM_BOOKMARK,
- &error);
+ scoped_refptr<Extension> extension =
+ Extension::Create(temp_dir.GetPath(), Manifest::INTERNAL, *root,
+ Extension::FROM_BOOKMARK, &error);
if (!extension.get()) {
LOG(ERROR) << error;
return NULL;
« no previous file with comments | « chrome/browser/extensions/convert_user_script_unittest.cc ('k') | chrome/browser/extensions/convert_web_app_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698