Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)
Patch Set: Comment addressed Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
index 508c7db0c2583325f80475923f7bc6f55bb1992e..52639e12c40e9c9d6dd5b88b67153dd882d6a964 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
@@ -138,9 +138,9 @@ const Extension* DeveloperPrivateApiUnitTest::LoadUnpackedExtension() {
TestExtensionRegistryObserver registry_observer(registry());
scoped_refptr<UnpackedInstaller> installer(
UnpackedInstaller::Create(service()));
- installer->Load(dir->unpacked_path());
+ installer->Load(dir->UnpackedPath());
base::FilePath extension_path =
- base::MakeAbsoluteFilePath(dir->unpacked_path());
+ base::MakeAbsoluteFilePath(dir->UnpackedPath());
const Extension* extension = nullptr;
do {
extension = registry_observer.WaitForExtensionLoaded();
@@ -303,11 +303,12 @@ TEST_F(DeveloperPrivateApiUnitTest, DeveloperPrivatePackFunction) {
base::ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
base::FilePath root_path = data_dir().AppendASCII("good_unpacked");
- ASSERT_TRUE(base::CopyDirectory(root_path, temp_dir.path(), true));
+ ASSERT_TRUE(base::CopyDirectory(root_path, temp_dir.GetPath(), true));
- base::FilePath temp_root_path = temp_dir.path().Append(root_path.BaseName());
- base::FilePath crx_path = temp_dir.path().AppendASCII("good_unpacked.crx");
- base::FilePath pem_path = temp_dir.path().AppendASCII("good_unpacked.pem");
+ base::FilePath temp_root_path =
+ temp_dir.GetPath().Append(root_path.BaseName());
+ base::FilePath crx_path = temp_dir.GetPath().AppendASCII("good_unpacked.crx");
+ base::FilePath pem_path = temp_dir.GetPath().AppendASCII("good_unpacked.pem");
EXPECT_FALSE(base::PathExists(crx_path))
<< "crx should not exist before the test is run!";

Powered by Google App Engine
This is Rietveld 408576698