chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc - Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Comment addressed Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc ('k') | chrome/common/extensions/chrome_manifest_url_handlers_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

diff --git a/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc b/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

index be03b518a800707ca2fd2364446623cfa36bc5d3..8bbcc5b977c8fd468b6901c50feb83799a8146a4 100644

--- a/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

+++ b/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

@@ -37,12 +37,12 @@ class StorageSchemaManifestHandlerTest : public testing::Test {

scoped_refptr<Extension> CreateExtension(const std::string& schema) {

std::string error;

- scoped_refptr<Extension> extension = Extension::Create(

- temp_dir_.path(), Manifest::UNPACKED, manifest_,

- Extension::NO_FLAGS, "", &error);

+ scoped_refptr<Extension> extension =

+ Extension::Create(temp_dir_.GetPath(), Manifest::UNPACKED, manifest_,

+ Extension::NO_FLAGS, "", &error);

if (!extension.get())

return NULL;

- base::FilePath schema_path = temp_dir_.path().AppendASCII("schema.json");

+ base::FilePath schema_path = temp_dir_.GetPath().AppendASCII("schema.json");

if (schema.empty()) {

base::DeleteFile(schema_path, false);

} else {