chrome/common/extensions/chrome_manifest_url_handlers_unittest.cc - Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/chrome_manifest_url_handlers_unittest.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Comment addressed Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/chrome_manifest_url_handlers_unittest.cc

diff --git a/chrome/common/extensions/chrome_manifest_url_handlers_unittest.cc b/chrome/common/extensions/chrome_manifest_url_handlers_unittest.cc

index aed51ad17fecfdd856f4030ba75fdf9965ddf7b3..458d6782520714c96c736603ed7d9467469f1c27 100644

--- a/chrome/common/extensions/chrome_manifest_url_handlers_unittest.cc

+++ b/chrome/common/extensions/chrome_manifest_url_handlers_unittest.cc

@@ -26,7 +26,7 @@ TEST(ChromeURLOverridesHandlerTest, TestFileMissing) {

base::ScopedTempDir dir;

ASSERT_TRUE(dir.CreateUniqueTempDir());

scoped_refptr<Extension> extension =

- Extension::Create(dir.path(), Manifest::INTERNAL, *manifest_value,

+ Extension::Create(dir.GetPath(), Manifest::INTERNAL, *manifest_value,

Extension::NO_FLAGS, std::string(), &error);

ASSERT_TRUE(extension);

EXPECT_FALSE(