Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: chrome/browser/extensions/convert_web_app_unittest.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)
Patch Set: Comment addressed Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/convert_web_app.h" 5 #include "chrome/browser/extensions/convert_web_app.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 web_app.app_url = GURL("http://aaronboodman.com/gearpad/"); 110 web_app.app_url = GURL("http://aaronboodman.com/gearpad/");
111 111
112 const int sizes[] = {16, 48, 128}; 112 const int sizes[] = {16, 48, 128};
113 for (size_t i = 0; i < arraysize(sizes); ++i) { 113 for (size_t i = 0; i < arraysize(sizes); ++i) {
114 GURL icon_url( 114 GURL icon_url(
115 web_app.app_url.Resolve(base::StringPrintf("%i.png", sizes[i]))); 115 web_app.app_url.Resolve(base::StringPrintf("%i.png", sizes[i])));
116 web_app.icons.push_back(GetIconInfo(icon_url, sizes[i])); 116 web_app.icons.push_back(GetIconInfo(icon_url, sizes[i]));
117 } 117 }
118 118
119 scoped_refptr<Extension> extension = ConvertWebAppToExtension( 119 scoped_refptr<Extension> extension = ConvertWebAppToExtension(
120 web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0), 120 web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0), extensions_dir.GetPath());
121 extensions_dir.path());
122 ASSERT_TRUE(extension.get()); 121 ASSERT_TRUE(extension.get());
123 122
124 base::ScopedTempDir extension_dir; 123 base::ScopedTempDir extension_dir;
125 EXPECT_TRUE(extension_dir.Set(extension->path())); 124 EXPECT_TRUE(extension_dir.Set(extension->path()));
126 125
127 EXPECT_TRUE(extension->is_app()); 126 EXPECT_TRUE(extension->is_app());
128 EXPECT_TRUE(extension->is_hosted_app()); 127 EXPECT_TRUE(extension->is_hosted_app());
129 EXPECT_FALSE(extension->is_legacy_packaged_app()); 128 EXPECT_FALSE(extension->is_legacy_packaged_app());
130 129
131 EXPECT_EQ("zVvdNZy3Mp7CFU8JVSyXNlDuHdVLbP7fDO3TGVzj/0w=", 130 EXPECT_EQ("zVvdNZy3Mp7CFU8JVSyXNlDuHdVLbP7fDO3TGVzj/0w=",
(...skipping 24 matching lines...) Expand all
156 155
157 TEST(ExtensionFromWebApp, Minimal) { 156 TEST(ExtensionFromWebApp, Minimal) {
158 base::ScopedTempDir extensions_dir; 157 base::ScopedTempDir extensions_dir;
159 ASSERT_TRUE(extensions_dir.CreateUniqueTempDir()); 158 ASSERT_TRUE(extensions_dir.CreateUniqueTempDir());
160 159
161 WebApplicationInfo web_app; 160 WebApplicationInfo web_app;
162 web_app.title = base::ASCIIToUTF16("Gearpad"); 161 web_app.title = base::ASCIIToUTF16("Gearpad");
163 web_app.app_url = GURL("http://aaronboodman.com/gearpad/"); 162 web_app.app_url = GURL("http://aaronboodman.com/gearpad/");
164 163
165 scoped_refptr<Extension> extension = ConvertWebAppToExtension( 164 scoped_refptr<Extension> extension = ConvertWebAppToExtension(
166 web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0), 165 web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0), extensions_dir.GetPath());
167 extensions_dir.path());
168 ASSERT_TRUE(extension.get()); 166 ASSERT_TRUE(extension.get());
169 167
170 base::ScopedTempDir extension_dir; 168 base::ScopedTempDir extension_dir;
171 EXPECT_TRUE(extension_dir.Set(extension->path())); 169 EXPECT_TRUE(extension_dir.Set(extension->path()));
172 170
173 EXPECT_TRUE(extension->is_app()); 171 EXPECT_TRUE(extension->is_app());
174 EXPECT_TRUE(extension->is_hosted_app()); 172 EXPECT_TRUE(extension->is_hosted_app());
175 EXPECT_FALSE(extension->is_legacy_packaged_app()); 173 EXPECT_FALSE(extension->is_legacy_packaged_app());
176 174
177 EXPECT_EQ("zVvdNZy3Mp7CFU8JVSyXNlDuHdVLbP7fDO3TGVzj/0w=", 175 EXPECT_EQ("zVvdNZy3Mp7CFU8JVSyXNlDuHdVLbP7fDO3TGVzj/0w=",
178 extension->public_key()); 176 extension->public_key());
179 EXPECT_EQ("oplhagaaipaimkjlbekcdjkffijdockj", extension->id()); 177 EXPECT_EQ("oplhagaaipaimkjlbekcdjkffijdockj", extension->id());
180 EXPECT_EQ("1978.12.11.0", extension->version()->GetString()); 178 EXPECT_EQ("1978.12.11.0", extension->version()->GetString());
181 EXPECT_EQ(base::UTF16ToUTF8(web_app.title), extension->name()); 179 EXPECT_EQ(base::UTF16ToUTF8(web_app.title), extension->name());
182 EXPECT_EQ("", extension->description()); 180 EXPECT_EQ("", extension->description());
183 EXPECT_EQ(web_app.app_url, AppLaunchInfo::GetFullLaunchURL(extension.get())); 181 EXPECT_EQ(web_app.app_url, AppLaunchInfo::GetFullLaunchURL(extension.get()));
184 EXPECT_EQ(0u, IconsInfo::GetIcons(extension.get()).map().size()); 182 EXPECT_EQ(0u, IconsInfo::GetIcons(extension.get()).map().size());
185 EXPECT_EQ(0u, 183 EXPECT_EQ(0u,
186 extension->permissions_data()->active_permissions().apis().size()); 184 extension->permissions_data()->active_permissions().apis().size());
187 ASSERT_EQ(0u, extension->web_extent().patterns().size()); 185 ASSERT_EQ(0u, extension->web_extent().patterns().size());
188 } 186 }
189 187
190 } // namespace extensions 188 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/convert_web_app.cc ('k') | chrome/browser/extensions/crx_installer_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698