chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc - Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Comment addressed Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/test_utils.cc ('k') | chrome/browser/extensions/api/management/management_api_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc b/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc

index 22f12d8d5eef0360fe9f56ba4d5d0d7f659bcc5d..feea07d33dd9ae24915dc9115cc89da91a672eca 100644

--- a/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc

+++ b/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc

@@ -58,14 +58,14 @@ void WriteFromUrlOperation::GetDownloadTarget(

}

if (url_.ExtractFileName().empty()) {

- if (!base::CreateTemporaryFileInDir(temp_dir_.path(), &image_path_)) {

+ if (!base::CreateTemporaryFileInDir(temp_dir_.GetPath(), &image_path_)) {

Error(error::kTempFileError);

return;

}

} else {

base::FilePath file_name =

base::FilePath::FromUTF8Unsafe(url_.ExtractFileName());

- image_path_ = temp_dir_.path().Append(file_name);

+ image_path_ = temp_dir_.GetPath().Append(file_name);

}

BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE, continuation);