Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4989)

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)
Patch Set: Comment addressed Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
diff --git a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
index d972bc0bcd4092c96e6087a586a4f54fe8c73928..c5ba9db21ff799b52d732f57310efc94d03fe151 100644
--- a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
+++ b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
@@ -259,7 +259,7 @@ class ExtensionGCMAppHandlerTest : public testing::Test {
TestExtensionSystem* extension_system(
static_cast<TestExtensionSystem*>(ExtensionSystem::Get(profile())));
base::FilePath extensions_install_dir =
- temp_dir_.path().Append(FILE_PATH_LITERAL("Extensions"));
+ temp_dir_.GetPath().Append(FILE_PATH_LITERAL("Extensions"));
extension_system->CreateExtensionService(
base::CommandLine::ForCurrentProcess(), extensions_install_dir, false);
extension_service_ = extension_system->Get(profile())->extension_service();
@@ -293,12 +293,8 @@ class ExtensionGCMAppHandlerTest : public testing::Test {
std::string error;
scoped_refptr<Extension> extension = Extension::Create(
- temp_dir_.path(),
- Manifest::UNPACKED,
- manifest,
- Extension::NO_FLAGS,
- "ldnnhddmnhbkjipkidpdiheffobcpfmf",
- &error);
+ temp_dir_.GetPath(), Manifest::UNPACKED, manifest, Extension::NO_FLAGS,
+ "ldnnhddmnhbkjipkidpdiheffobcpfmf", &error);
EXPECT_TRUE(extension.get()) << error;
EXPECT_TRUE(
extension->permissions_data()->HasAPIPermission(APIPermission::kGcm));
@@ -327,7 +323,7 @@ class ExtensionGCMAppHandlerTest : public testing::Test {
data_dir = data_dir.AppendASCII("extensions");
data_dir = data_dir.AppendASCII(update_crx);
- base::FilePath path = temp_dir_.path();
+ base::FilePath path = temp_dir_.GetPath();
path = path.Append(data_dir.BaseName());
ASSERT_TRUE(base::CopyFile(data_dir, path));

Powered by Google App Engine
This is Rietveld 408576698