chrome/browser/extensions/api/i18n/i18n_apitest.cc - Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/i18n/i18n_apitest.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Comment addressed Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc ('k') | chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/i18n/i18n_apitest.cc

diff --git a/chrome/browser/extensions/api/i18n/i18n_apitest.cc b/chrome/browser/extensions/api/i18n/i18n_apitest.cc

index df1680949db9c4a4979d390ae30241cb77261090..db534d2d2682deafeada580aa0498ff7d4877c00 100644

--- a/chrome/browser/extensions/api/i18n/i18n_apitest.cc

+++ b/chrome/browser/extensions/api/i18n/i18n_apitest.cc

@@ -24,20 +24,17 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, I18NUpdate) {

base::ScopedTempDir extension_dir;

ASSERT_TRUE(extension_dir.CreateUniqueTempDir());

base::CopyFile(

- test_data_dir_.AppendASCII("i18nUpdate")

- .AppendASCII("manifest.json"),

- extension_dir.path().AppendASCII("manifest.json"));

+ test_data_dir_.AppendASCII("i18nUpdate").AppendASCII("manifest.json"),

+ extension_dir.GetPath().AppendASCII("manifest.json"));

base::CopyFile(

- test_data_dir_.AppendASCII("i18nUpdate")

- .AppendASCII("contentscript.js"),

- extension_dir.path().AppendASCII("contentscript.js"));

+ test_data_dir_.AppendASCII("i18nUpdate").AppendASCII("contentscript.js"),

+ extension_dir.GetPath().AppendASCII("contentscript.js"));

base::CopyDirectory(

- test_data_dir_.AppendASCII("i18nUpdate")

- .AppendASCII("_locales"),

- extension_dir.path().AppendASCII("_locales"),

- true);

+ test_data_dir_.AppendASCII("i18nUpdate").AppendASCII("_locales"),

+ extension_dir.GetPath().AppendASCII("_locales"), true);

- const extensions::Extension* extension = LoadExtension(extension_dir.path());

+ const extensions::Extension* extension =

+ LoadExtension(extension_dir.GetPath());

extensions::ResultCatcher catcher;

@@ -53,9 +50,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, I18NUpdate) {

// Change messages.json file and reload extension.

base::CopyFile(

- test_data_dir_.AppendASCII("i18nUpdate")

- .AppendASCII("messages2.json"),

- extension_dir.path().AppendASCII("_locales/en/messages.json"));

+ test_data_dir_.AppendASCII("i18nUpdate").AppendASCII("messages2.json"),

+ extension_dir.GetPath().AppendASCII("_locales/en/messages.json"));

ReloadExtension(extension->id());

// Check that the i18n message is also changed.