Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: extensions/browser/api/storage/storage_frontend_unittest.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)
Patch Set: Comment addressed Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/runtime/runtime_apitest.cc ('k') | extensions/browser/computed_hashes_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/storage/storage_frontend_unittest.cc
diff --git a/extensions/browser/api/storage/storage_frontend_unittest.cc b/extensions/browser/api/storage/storage_frontend_unittest.cc
index 64339dbf4275c76ccf4f0f7a078c0bb74ca19fb0..6f37a2e11d1fb97e07c1571ab6496736fef6ab12 100644
--- a/extensions/browser/api/storage/storage_frontend_unittest.cc
+++ b/extensions/browser/api/storage/storage_frontend_unittest.cc
@@ -49,7 +49,7 @@ class ExtensionSettingsFrontendTest : public ExtensionsTest {
void SetUp() override {
ExtensionsTest::SetUp();
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
- storage_factory_ = new ValueStoreFactoryImpl(temp_dir_.path());
+ storage_factory_ = new ValueStoreFactoryImpl(temp_dir_.GetPath());
ResetFrontend();
}
@@ -163,7 +163,7 @@ TEST_F(ExtensionSettingsFrontendTest, LeveldbDatabaseDeletedFromDiskOnClear) {
base::StringValue bar("bar");
ValueStore::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
ASSERT_TRUE(result->status().ok());
- EXPECT_TRUE(base::PathExists(temp_dir_.path()));
+ EXPECT_TRUE(base::PathExists(temp_dir_.GetPath()));
}
// Should need to both clear the database and delete the frontend for the
@@ -171,7 +171,7 @@ TEST_F(ExtensionSettingsFrontendTest, LeveldbDatabaseDeletedFromDiskOnClear) {
{
ValueStore::WriteResult result = storage->Clear();
ASSERT_TRUE(result->status().ok());
- EXPECT_TRUE(base::PathExists(temp_dir_.path()));
+ EXPECT_TRUE(base::PathExists(temp_dir_.GetPath()));
}
frontend_.reset();
@@ -179,7 +179,7 @@ TEST_F(ExtensionSettingsFrontendTest, LeveldbDatabaseDeletedFromDiskOnClear) {
// TODO(kalman): Figure out why this fails, despite appearing to work.
// Leaving this commented out rather than disabling the whole test so that the
// deletion code paths are at least exercised.
- //EXPECT_FALSE(base::PathExists(temp_dir_.path()));
+ // EXPECT_FALSE(base::PathExists(temp_dir_.GetPath()));
}
// Disabled (slow), http://crbug.com/322751 .
« no previous file with comments | « extensions/browser/api/runtime/runtime_apitest.cc ('k') | extensions/browser/computed_hashes_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698