chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc - Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Comment addressed Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc ('k') | chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc

diff --git a/chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc b/chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc

index 0a209503948e4f6836586d32cb98683d12a03b54..5c0a5003d550e15c05f33e0979db400a93b5eb9d 100644

--- a/chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc

+++ b/chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc

@@ -110,7 +110,7 @@ class MediaGalleriesGalleryWatchApiTest : public ExtensionApiTest {

bool AddNewFileInTestGallery() {

base::FilePath gallery_file =

- test_gallery_.path().Append(FILE_PATH_LITERAL("test1.txt"));

+ test_gallery_.GetPath().Append(FILE_PATH_LITERAL("test1.txt"));

std::string content("new content");

int write_size =

base::WriteFile(gallery_file, content.c_str(), content.length());

@@ -147,8 +147,8 @@ class MediaGalleriesGalleryWatchApiTest : public ExtensionApiTest {

ASSERT_TRUE(test_gallery_.CreateUniqueTempDir());

MediaGalleryPrefInfo gallery_info;

- ASSERT_FALSE(

- preferences->LookUpGalleryByPath(test_gallery_.path(), &gallery_info));

+ ASSERT_FALSE(preferences->LookUpGalleryByPath(test_gallery_.GetPath(),

+ &gallery_info));

MediaGalleryPrefId id =

preferences->AddGallery(gallery_info.device_id,

gallery_info.path,