chrome/browser/devtools/devtools_sanity_browsertest.cc - Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath()

Side by Side Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Comment addressed Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_database_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <stddef.h>	5 #include <stddef.h>

6	6

7 #include <memory>	7 #include <memory>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/cancelable_callback.h"	10 #include "base/cancelable_callback.h"

(...skipping 924 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
935 " }\n"	935 " }\n"

936 ");\n");	936 ");\n");

937	937

938 GURL http_iframe =	938 GURL http_iframe =

939 embedded_test_server()->GetURL("a.com", "/popup_iframe.html");	939 embedded_test_server()->GetURL("a.com", "/popup_iframe.html");

940 dir->WriteFile(FILE_PATH_LITERAL("panel.html"),	940 dir->WriteFile(FILE_PATH_LITERAL("panel.html"),

941 "<html><body>Extension panel.<iframe src='" +	941 "<html><body>Extension panel.<iframe src='" +

942 http_iframe.spec() + "'></iframe>");	942 http_iframe.spec() + "'></iframe>");

943	943

944 // Install the extension.	944 // Install the extension.

945 const Extension* extension = LoadExtensionFromPath(dir->unpacked_path());	945 const Extension* extension = LoadExtensionFromPath(dir->UnpackedPath());

946 ASSERT_TRUE(extension);	946 ASSERT_TRUE(extension);

947	947

948 // Open a devtools window.	948 // Open a devtools window.

949 OpenDevToolsWindow(kDebuggerTestPage, false);	949 OpenDevToolsWindow(kDebuggerTestPage, false);

950	950

951 // Wait for the panel extension to finish loading -- it'll output 'PASS'	951 // Wait for the panel extension to finish loading -- it'll output 'PASS'

952 // when it's installed. waitForTestResultsInConsole waits until that 'PASS'.	952 // when it's installed. waitForTestResultsInConsole waits until that 'PASS'.

953 RunTestFunction(window_, "waitForTestResultsInConsole");	953 RunTestFunction(window_, "waitForTestResultsInConsole");

954	954

955 // Now that we know the panel is loaded, switch to it. We'll wait until we	955 // Now that we know the panel is loaded, switch to it. We'll wait until we

(...skipping 491 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1447 DevToolsWindowTesting::OpenDevToolsWindowSync(GetInspectedTab(), true);	1447 DevToolsWindowTesting::OpenDevToolsWindowSync(GetInspectedTab(), true);

1448 chrome::DuplicateTab(browser());	1448 chrome::DuplicateTab(browser());

1449 chrome::SelectPreviousTab(browser());	1449 chrome::SelectPreviousTab(browser());

1450 ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));	1450 ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));

1451 chrome::GoBack(browser(), WindowOpenDisposition::CURRENT_TAB);	1451 chrome::GoBack(browser(), WindowOpenDisposition::CURRENT_TAB);

1452 RunTestFunction(window, "testWindowInitializedOnNavigateBack");	1452 RunTestFunction(window, "testWindowInitializedOnNavigateBack");

1453	1453

1454 DevToolsWindowTesting::CloseDevToolsWindowSync(window);	1454 DevToolsWindowTesting::CloseDevToolsWindowSync(window);

1455 content::WebUIControllerFactory::UnregisterFactoryForTesting(&test_factory);	1455 content::WebUIControllerFactory::UnregisterFactoryForTesting(&test_factory);

1456 }	1456 }

OLD	NEW