Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage

Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage
new uses of the flag and thus reduce the cost when it's finally removed.

BUG=516499
R=mmenke@chromium.org
TBR=megjablon@chromium.org
TBR=pkasting@chromium.org
TBR=droger@chromium.org

Committed: https://crrev.com/4de1fcfedc5084259f7c9bf8eb04483097a86df2
Cr-Commit-Position: refs/heads/master@{#415164}

[Randy Smith (Not in Mondays), 2016-08-25 18:24:44]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 18:25:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2016-08-25 18:56:58]

Matt, PTAL whenever you had a chance.  It's a big ole query/replace and a small
doc mod--shouldn't take too long.

[mmenke, 2016-08-25 19:16:07]

This LGTM, except for that failing test.  You should remove the MAIN_FRAME load
flag from that net-internals test.

[commit-bot: I haz the power, 2016-08-25 19:18:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 19:18:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Randy Smith (Not in Mondays), 2016-08-25 21:09:31]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:10:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:44:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:44:26]

Dry run: This issue passed the CQ dry run.

[Randy Smith (Not in Mondays), 2016-08-29 14:39:57]

The CQ bit was checked by rdsmith@chromium.org

[Randy Smith (Not in Mondays), 2016-08-29 14:39:57]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2278823003/#ps20001
(title: "Modified JS references to MAIN_FRAME.")

[commit-bot: I haz the power, 2016-08-29 14:40:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 14:47:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 14:47:49]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Randy Smith (Not in Mondays), 2016-08-29 14:53:03]

rdsmith@chromium.org changed reviewers:
+ droger@chromium.org, megjablon@chromium.org, pkasting@chromium.org

[Randy Smith (Not in Mondays), 2016-08-29 14:53:04]

Requesting owner stamps?:

* components/data_reduction_proxy: megjablon@
* chrome/browser/ui: pkasting@
* ios/chrome/browser: droger@

[mmenke, 2016-08-29 15:08:10]

On 2016/08/29 14:53:04, Randy Smith - Not in Fridays wrote:
> Requesting owner stamps?:
> 
> * components/data_reduction_proxy: megjablon@
> * chrome/browser/ui: pkasting@
> * ios/chrome/browser: droger@

This CL seems pretty TBR-worthy to me, unless you want to tell existing
consumers that we want this value to go away.

[Randy Smith (Not in Mondays), 2016-08-29 15:12:53]

On 2016/08/29 15:08:10, mmenke wrote:
> On 2016/08/29 14:53:04, Randy Smith - Not in Fridays wrote:
> > Requesting owner stamps?:
> > 
> > * components/data_reduction_proxy: megjablon@
> > * chrome/browser/ui: pkasting@
> > * ios/chrome/browser: droger@
> 
> This CL seems pretty TBR-worthy to me, unless you want to tell existing
> consumers that we want this value to go away.

Good point, I hadn't considered that option.  I'll do that.

[Randy Smith (Not in Mondays), 2016-08-29 15:13:29]

Description was changed from

==========
Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage
new uses of the flag and thus reduce the cost when it's finally removed.

BUG=516499
R=mmenke@chromium.org
==========

to

==========
Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage
new uses of the flag and thus reduce the cost when it's finally removed.

BUG=516499
R=mmenke@chromium.org
TBR=megjablon@chromium.org
TBR=pkasting@chromium.org
TBR=droger@chromium.org
==========

[Randy Smith (Not in Mondays), 2016-08-29 15:24:32]

The CQ bit was checked by rdsmith@chromium.org

[Randy Smith (Not in Mondays), 2016-08-29 15:24:33]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2278823003/#ps40001
(title: "Added deprecation flag to two recent tests.")

[commit-bot: I haz the power, 2016-08-29 15:24:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[droger, 2016-08-29 15:47:10]

ios lgtm

[dsansome, 2016-08-30 01:46:02]

The CQ bit was unchecked by dsansome@chromium.org

[Peter Kasting, 2016-08-30 01:59:16]

LGTM, yeah TBR is fine for this

[dsansome, 2016-08-30 03:54:51]

dsansome@chromium.org changed reviewers:
+ dsansome@chromium.org

[dsansome, 2016-08-30 03:54:52]

(I unset the commit bit on this change to try fix a stuck CQ -
https://bugs.chromium.org/p/chromium/issues/detail?id=642077.  The issue is
fixed now so I'm sending this to CQ again for you)

[dsansome, 2016-08-30 03:55:49]

The CQ bit was checked by dsansome@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:57:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:35:38]

Description was changed from

==========
Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage
new uses of the flag and thus reduce the cost when it's finally removed.

BUG=516499
R=mmenke@chromium.org
TBR=megjablon@chromium.org
TBR=pkasting@chromium.org
TBR=droger@chromium.org
==========

to

==========
Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage
new uses of the flag and thus reduce the cost when it's finally removed.

BUG=516499
R=mmenke@chromium.org
TBR=megjablon@chromium.org
TBR=pkasting@chromium.org
TBR=droger@chromium.org
==========

[commit-bot: I haz the power, 2016-08-30 05:35:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 05:38:26]

Description was changed from

==========
Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage
new uses of the flag and thus reduce the cost when it's finally removed.

BUG=516499
R=mmenke@chromium.org
TBR=megjablon@chromium.org
TBR=pkasting@chromium.org
TBR=droger@chromium.org
==========

to

==========
Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage
new uses of the flag and thus reduce the cost when it's finally removed.

BUG=516499
R=mmenke@chromium.org
TBR=megjablon@chromium.org
TBR=pkasting@chromium.org
TBR=droger@chromium.org

Committed: https://crrev.com/4de1fcfedc5084259f7c9bf8eb04483097a86df2
Cr-Commit-Position: refs/heads/master@{#415164}
==========

[commit-bot: I haz the power, 2016-08-30 05:38:28]

Patchset 3 (id:??) landed as
https://crrev.com/4de1fcfedc5084259f7c9bf8eb04483097a86df2
Cr-Commit-Position: refs/heads/master@{#415164}