Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: net/http/http_cache_transaction.cc

Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added deprecation flag to two recent tests. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/load_flags_list.h ('k') | net/http/http_network_transaction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_cache_transaction.cc
diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc
index 489e49605fd45c0081aa87a22012772c7f853e86..c429c3db4aa78db731187e23d5627fdf3083c8c4 100644
--- a/net/http/http_cache_transaction.cc
+++ b/net/http/http_cache_transaction.cc
@@ -65,7 +65,7 @@ bool NonErrorResponse(int status_code) {
void RecordNoStoreHeaderHistogram(int load_flags,
const HttpResponseInfo* response) {
- if (load_flags & LOAD_MAIN_FRAME) {
+ if (load_flags & LOAD_MAIN_FRAME_DEPRECATED) {
UMA_HISTOGRAM_BOOLEAN(
"Net.MainFrameNoStore",
response->headers->HasHeaderValue("cache-control", "no-store"));
@@ -2821,7 +2821,8 @@ void HttpCache::Transaction::RecordHistograms() {
// Record the cache pattern by resource type. The type is inferred by
// response header mime type, which could be incorrect, so this is just an
// estimate.
- if (mime_type == "text/html" && (request_->load_flags & LOAD_MAIN_FRAME)) {
+ if (mime_type == "text/html" &&
+ (request_->load_flags & LOAD_MAIN_FRAME_DEPRECATED)) {
UMA_HISTOGRAM_ENUMERATION("HttpCache.Pattern.MainFrameHTML",
cache_entry_status_,
CacheEntryStatus::ENTRY_MAX);
« no previous file with comments | « net/base/load_flags_list.h ('k') | net/http/http_network_transaction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698