chrome/browser/ui/login/login_handler.cc - Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/login/login_handler.cc

Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added deprecation flag to two recent tests. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/login/login_handler.cc

diff --git a/chrome/browser/ui/login/login_handler.cc b/chrome/browser/ui/login/login_handler.cc

index 2dc06ed0baf7fa3c55eddfc4ce1a96db52c97f72..926540da7ae6421437d782642093bcd70b349711 100644

--- a/chrome/browser/ui/login/login_handler.cc

+++ b/chrome/browser/ui/login/login_handler.cc

@@ -647,7 +647,8 @@ void LoginHandler::LoginDialogCallback(const GURL& request_url,

LoginHandler* CreateLoginPrompt(net::AuthChallengeInfo* auth_info,

net::URLRequest* request) {

- bool is_main_frame = (request->load_flags() & net::LOAD_MAIN_FRAME) != 0;

+ bool is_main_frame =

+ (request->load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) != 0;

LoginHandler* handler = LoginHandler::Create(auth_info, request);

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,

« no previous file with comments | « chrome/browser/net/chrome_network_delegate.cc ('k') | chrome/test/data/webui/net_internals/log_view_painter.js » ('j') | no next file with comments »