Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc

Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added deprecation flag to two recent tests. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
diff --git a/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc b/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
index a2c43414ca64a852acdf2254088e3390f398c031..0af5c809c59c76a0d2304adb2c496dc365b1c632 100644
--- a/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
+++ b/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
@@ -207,7 +207,8 @@ TEST_F(ContentLoFiDeciderTest, LoFiFlags) {
switches::kDataReductionProxyLoFi,
switches::kDataReductionProxyLoFiValueAlwaysOn);
if (tests[i].is_main_frame)
- request->SetLoadFlags(request->load_flags() | net::LOAD_MAIN_FRAME);
+ request->SetLoadFlags(request->load_flags() |
+ net::LOAD_MAIN_FRAME_DEPRECATED);
headers.Clear();
NotifyBeforeSendHeaders(&headers, request.get(), true);
VerifyLoFiHeader(tests[i].is_using_lofi && !tests[i].is_using_previews &&
@@ -284,7 +285,8 @@ TEST_F(ContentLoFiDeciderTest, LoFiEnabledFieldTrial) {
std::unique_ptr<net::URLRequest> request =
CreateRequest(tests[i].is_using_lofi);
if (tests[i].is_main_frame)
- request->SetLoadFlags(request->load_flags() | net::LOAD_MAIN_FRAME);
+ request->SetLoadFlags(request->load_flags() |
+ net::LOAD_MAIN_FRAME_DEPRECATED);
net::HttpRequestHeaders headers;
NotifyBeforeSendHeaders(&headers, request.get(), true);
VerifyLoFiHeader(tests[i].is_using_lofi && !tests[i].is_main_frame,
@@ -310,7 +312,8 @@ TEST_F(ContentLoFiDeciderTest, LoFiControlFieldTrial) {
std::unique_ptr<net::URLRequest> request =
CreateRequest(tests[i].is_using_lofi);
if (tests[i].is_main_frame)
- request->SetLoadFlags(request->load_flags() | net::LOAD_MAIN_FRAME);
+ request->SetLoadFlags(request->load_flags() |
+ net::LOAD_MAIN_FRAME_DEPRECATED);
net::HttpRequestHeaders headers;
NotifyBeforeSendHeaders(&headers, request.get(), true);
VerifyLoFiHeader(false, headers);
@@ -337,7 +340,8 @@ TEST_F(ContentLoFiDeciderTest, LoFiPreviewFieldTrial) {
std::unique_ptr<net::URLRequest> request =
CreateRequest(tests[i].is_using_lofi);
if (tests[i].is_main_frame)
- request->SetLoadFlags(request->load_flags() | net::LOAD_MAIN_FRAME);
+ request->SetLoadFlags(request->load_flags() |
+ net::LOAD_MAIN_FRAME_DEPRECATED);
net::HttpRequestHeaders headers;
NotifyBeforeSendHeaders(&headers, request.get(), true);
VerifyLoFiHeader(false, headers);
@@ -391,7 +395,8 @@ TEST_F(ContentLoFiDeciderTest, AutoLoFi) {
std::unique_ptr<net::URLRequest> request =
CreateRequest(tests[i].network_prohibitively_slow);
if (tests[i].is_main_frame)
- request->SetLoadFlags(request->load_flags() | net::LOAD_MAIN_FRAME);
+ request->SetLoadFlags(request->load_flags() |
+ net::LOAD_MAIN_FRAME_DEPRECATED);
net::HttpRequestHeaders headers;
NotifyBeforeSendHeaders(&headers, request.get(), true);
@@ -446,7 +451,8 @@ TEST_F(ContentLoFiDeciderTest, SlowConnectionsFlag) {
std::unique_ptr<net::URLRequest> request =
CreateRequest(tests[i].network_prohibitively_slow);
if (tests[i].is_main_frame)
- request->SetLoadFlags(request->load_flags() | net::LOAD_MAIN_FRAME);
+ request->SetLoadFlags(request->load_flags() |
+ net::LOAD_MAIN_FRAME_DEPRECATED);
net::HttpRequestHeaders headers;
NotifyBeforeSendHeaders(&headers, request.get(), true);

Powered by Google App Engine
This is Rietveld 408576698