net/url_request/url_request_job.cc - Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_job.cc

Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added deprecation flag to two recent tests. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request_job.cc

diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc

index 4224b4c67792ccc2b3f92124a820f5cbec5ab634..5b4fefec786b9c15740998304a24a6d25fc68893 100644

--- a/net/url_request/url_request_job.cc

+++ b/net/url_request/url_request_job.cc

@@ -630,7 +630,7 @@ void URLRequestJob::NotifyDone(const URLRequestStatus &status) {

int response_code = GetResponseCode();

if (400 <= response_code && response_code <= 599) {

bool page_has_content = (postfilter_bytes_read_ != 0);

- if (request_->load_flags() & net::LOAD_MAIN_FRAME) {

+ if (request_->load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) {

UMA_HISTOGRAM_BOOLEAN("Net.ErrorResponseHasContentMainFrame",

page_has_content);

} else {

« no previous file with comments | « net/nqe/network_quality_estimator_unittest.cc ('k') | no next file » | no next file with comments »