components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc - Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added deprecation flag to two recent tests. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

index cf10444a3bc69c717846123f823af429e3324ce0..5d7f8fe2cb1f5212fe0cb56fc657a5a0cb07b19b 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

@@ -845,7 +845,8 @@ TEST_F(DataReductionProxyConfigTest, LoFiOn) {

net::TestDelegate delegate_;

std::unique_ptr<net::URLRequest> request =

context_.CreateRequest(GURL(), net::IDLE, &delegate_);

- request->SetLoadFlags(request->load_flags() | net::LOAD_MAIN_FRAME);

+ request->SetLoadFlags(request->load_flags() |

+ net::LOAD_MAIN_FRAME_DEPRECATED);

bool should_enable_lofi = config()->ShouldEnableLoFiMode(*request.get());

if (tests[i].expect_bucket_count != 0) {

histogram_tester.ExpectBucketCount(