components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc - Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc

Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added deprecation flag to two recent tests. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc

index a06f4d2317d8a7c27329e59a0b74ecadadb1db20..cce040151145eee51ee255b3a9005d46c0e1a3d8 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc

@@ -134,7 +134,7 @@ void DataReductionProxyBypassStats::OnUrlRequestCompleted(

UMA_HISTOGRAM_COUNTS_100(

"DataReductionProxy.SuccessfulRequestCompletionCounts",

proxy_info.proxy_index);

- if (request->load_flags() & net::LOAD_MAIN_FRAME) {

+ if (request->load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) {

UMA_HISTOGRAM_COUNTS_100(

"DataReductionProxy.SuccessfulRequestCompletionCounts.MainFrame",

proxy_info.proxy_index);