components/data_reduction_proxy/content/browser/content_lofi_decider.cc - Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/content/browser/content_lofi_decider.cc

Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added deprecation flag to two recent tests. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/net_internals/log_view_painter.js ('k') | components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/content/browser/content_lofi_decider.cc

diff --git a/components/data_reduction_proxy/content/browser/content_lofi_decider.cc b/components/data_reduction_proxy/content/browser/content_lofi_decider.cc

index 0523f7ea334d6491e054aff2c6ec23d2cd15dd9b..e2f4b96cf767fb3af33e10bcaf7ba2f974bf7be5 100644

--- a/components/data_reduction_proxy/content/browser/content_lofi_decider.cc

+++ b/components/data_reduction_proxy/content/browser/content_lofi_decider.cc

@@ -69,14 +69,14 @@ bool ContentLoFiDecider::MaybeAddLoFiDirectiveToHeaders(

// "q=preview" directive on main frame requests. Do not add Lo-Fi directives

// to other requests when previews are enabled.

if (lofi_preview_via_flag_or_field_trial) {

- if (request.load_flags() & net::LOAD_MAIN_FRAME) {

+ if (request.load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) {

if (params::AreLoFiPreviewsEnabledViaFlags()) {

header_value += chrome_proxy_lo_fi_ignore_preview_blacklist_directive();

header_value += ", ";

}

header_value += chrome_proxy_lo_fi_preview_directive();

}

- } else if (!(request.load_flags() & net::LOAD_MAIN_FRAME)) {

+ } else if (!(request.load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED)) {

// If previews are not enabled, add "q=low" for requests that are not main

// frame.

header_value += chrome_proxy_lo_fi_directive();