Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: content/browser/loader/async_revalidation_manager.cc

Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added deprecation flag to two recent tests. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/async_revalidation_manager.h" 5 #include "content/browser/loader/async_revalidation_manager.h"
6 6
7 #include <tuple> 7 #include <tuple>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 new_request->set_first_party_for_cookies( 115 new_request->set_first_party_for_cookies(
116 for_request.first_party_for_cookies()); 116 for_request.first_party_for_cookies());
117 new_request->set_initiator(for_request.initiator()); 117 new_request->set_initiator(for_request.initiator());
118 new_request->set_first_party_url_policy(for_request.first_party_url_policy()); 118 new_request->set_first_party_url_policy(for_request.first_party_url_policy());
119 119
120 new_request->SetReferrer(for_request.referrer()); 120 new_request->SetReferrer(for_request.referrer());
121 new_request->set_referrer_policy(for_request.referrer_policy()); 121 new_request->set_referrer_policy(for_request.referrer_policy());
122 122
123 new_request->SetExtraRequestHeaders(headers); 123 new_request->SetExtraRequestHeaders(headers);
124 124
125 // Remove LOAD_SUPPORT_ASYNC_REVALIDATION and LOAD_MAIN_FRAME flags. 125 // Remove LOAD_SUPPORT_ASYNC_REVALIDATION and LOAD_MAIN_FRAME_DEPRECATED
126 // flags.
126 // Also remove things which shouldn't have been there to begin with, 127 // Also remove things which shouldn't have been there to begin with,
127 // and unrecognised flags. 128 // and unrecognised flags.
128 int load_flags = 129 int load_flags =
129 for_request.load_flags() & 130 for_request.load_flags() &
130 (net::LOAD_DO_NOT_SAVE_COOKIES | net::LOAD_BYPASS_PROXY | 131 (net::LOAD_DO_NOT_SAVE_COOKIES | net::LOAD_BYPASS_PROXY |
131 net::LOAD_VERIFY_EV_CERT | net::LOAD_DO_NOT_SEND_COOKIES | 132 net::LOAD_VERIFY_EV_CERT | net::LOAD_DO_NOT_SEND_COOKIES |
132 net::LOAD_DO_NOT_SEND_AUTH_DATA | net::LOAD_MAYBE_USER_GESTURE | 133 net::LOAD_DO_NOT_SEND_AUTH_DATA | net::LOAD_MAYBE_USER_GESTURE |
133 net::LOAD_DO_NOT_USE_EMBEDDED_IDENTITY); 134 net::LOAD_DO_NOT_USE_EMBEDDED_IDENTITY);
134 new_request->SetLoadFlags(load_flags); 135 new_request->SetLoadFlags(load_flags);
135 136
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 184
184 return true; 185 return true;
185 } 186 }
186 187
187 void AsyncRevalidationManager::OnAsyncRevalidationComplete( 188 void AsyncRevalidationManager::OnAsyncRevalidationComplete(
188 AsyncRevalidationMap::iterator it) { 189 AsyncRevalidationMap::iterator it) {
189 in_progress_.erase(it); 190 in_progress_.erase(it);
190 } 191 }
191 192
192 } // namespace content 193 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698