net/base/load_flags_list.h - Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/load_flags_list.h

Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added deprecation flag to two recent tests. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/load_flags_list.h

diff --git a/net/base/load_flags_list.h b/net/base/load_flags_list.h

index 28cbcba8db6b99f24c8c5103b989303d275b227a..1f030eaa788124fc10eabe281dd0cd42a1cee413 100644

--- a/net/base/load_flags_list.h

+++ b/net/base/load_flags_list.h

@@ -54,10 +54,14 @@ LOAD_FLAG(DO_NOT_SEND_AUTH_DATA, 1 << 10)

// This should only be used for testing (set by HttpNetworkTransaction).

LOAD_FLAG(IGNORE_ALL_CERT_ERRORS, 1 << 11)

+// DO NOT USE THIS FLAG

+// The network stack should not have frame level knowledge. Any pre-connect

+// or pre-resolution requiring that knowledge should be done from the

+// stack embedder.

// Indicate that this is a top level frame, so that we don't assume it is a

// subresource and speculatively pre-connect or pre-resolve when a referring

// page is loaded.

-LOAD_FLAG(MAIN_FRAME, 1 << 12)

+LOAD_FLAG(MAIN_FRAME_DEPRECATED, 1 << 12)

// Indicates that this load was motivated by the rel=prefetch feature,

// and is (in theory) not intended for the current frame.

« no previous file with comments | « ios/chrome/browser/net/ios_chrome_network_delegate.cc ('k') | net/http/http_cache_transaction.cc » ('j') | no next file with comments »