net/http/http_network_transaction.cc - Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction.cc

Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added deprecation flag to two recent tests. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_transaction.cc

diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc

index b5db3d24cf5990eeefdef97c443915a790d01ea9..5b59a957dffd6e8a75380e960a5d4fca8a006ea6 100644

--- a/net/http/http_network_transaction.cc

+++ b/net/http/http_network_transaction.cc

@@ -1191,7 +1191,7 @@ int HttpNetworkTransaction::DoReadHeadersComplete(int result) {

}

// Like Net.HttpResponseCode, but only for MAIN_FRAME loads.

- if (request_->load_flags & LOAD_MAIN_FRAME) {

+ if (request_->load_flags & LOAD_MAIN_FRAME_DEPRECATED) {

const int response_code = response_.headers->response_code();

UMA_HISTOGRAM_ENUMERATION(

"Net.HttpResponseCode_Nxx_MainFrame", response_code/100, 10);

« no previous file with comments | « net/http/http_cache_transaction.cc ('k') | net/nqe/network_quality_estimator.cc » ('j') | no next file with comments »