components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc - Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

Issue 2278823003: Change net::LOAD_MAIN_FRAME to net::LOAD_MAIN_FRAME_DEPRECATED to discourage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added deprecation flag to two recent tests. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

index f48244c6ca0c33a9f2041d0d8ac3dd170a69a0d5..f071ebb5a6e0f68d5824d913328cbddb5807d8a4 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

@@ -857,7 +857,7 @@ bool DataReductionProxyConfig::IsEffectiveConnectionTypeSlowerThanThreshold(

bool DataReductionProxyConfig::ShouldEnableLoFiMode(

const net::URLRequest& request) {

DCHECK(thread_checker_.CalledOnValidThread());

- DCHECK((request.load_flags() & net::LOAD_MAIN_FRAME) != 0);

+ DCHECK((request.load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) != 0);

DCHECK(!request.url().SchemeIsCryptographic());

net::NetworkQualityEstimator* network_quality_estimator;