Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() BUG=581865 Committed: https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c Cr-Commit-Position: refs/heads/master@{#397746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -85 lines) Patch
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/management/management_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/storage/settings_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/storage/storage_frontend.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/api/web_request/upload_data_presenter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/upload_data_presenter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M extensions/browser/event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/quota_service_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M extensions/common/extension_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/features/simple_feature_unittest.cc View 4 chunks +18 lines, -18 lines 0 comments Download
M extensions/common/file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/oauth2_manifest_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/api_permission_set_unittest.cc View 10 chunks +27 lines, -27 lines 0 comments Download
M extensions/common/value_builder.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/dom_activity_logger.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
4 years, 6 months ago (2016-06-03 04:38:15 UTC) #2
Devlin
lgtm
4 years, 6 months ago (2016-06-03 15:13:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037703004/1
4 years, 6 months ago (2016-06-03 17:33:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 17:38:33 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 17:40:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04f99a508817eeb89143a841c1d0ba1c2daf674c
Cr-Commit-Position: refs/heads/master@{#397746}

Powered by Google App Engine
This is Rietveld 408576698