Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: extensions/renderer/dom_activity_logger.cc

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/value_builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/dom_activity_logger.cc
diff --git a/extensions/renderer/dom_activity_logger.cc b/extensions/renderer/dom_activity_logger.cc
index 92055232c712df9582c1aa9b64a2596d6897e1c1..a7ecb7e26b4e6dc0d2c68c4fe1dcb6b7acdc1a18 100644
--- a/extensions/renderer/dom_activity_logger.cc
+++ b/extensions/renderer/dom_activity_logger.cc
@@ -109,7 +109,7 @@ void DOMActivityLogger::logEvent(const WebString& event_name,
std::unique_ptr<base::ListValue> args(new base::ListValue);
std::string event_name_utf8 = event_name.utf8();
for (int i = 0; i < argc; ++i)
- args->Append(new base::StringValue(argv[i]));
+ args->AppendString(argv[i]);
SendDomActionMessage(event_name_utf8, url, title, DomActionType::METHOD,
std::move(args));
}
« no previous file with comments | « extensions/common/value_builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698