Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Side by Side Diff: extensions/browser/api/storage/settings_test_util.cc

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/storage/settings_test_util.h" 5 #include "extensions/browser/api/storage/settings_test_util.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "extensions/browser/api/storage/storage_frontend.h" 8 #include "extensions/browser/api/storage/storage_frontend.h"
9 #include "extensions/browser/extension_registry.h" 9 #include "extensions/browser/extension_registry.h"
10 #include "extensions/browser/extension_system_provider.h" 10 #include "extensions/browser/extension_system_provider.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 const std::string& id, 67 const std::string& id,
68 Manifest::Type type, 68 Manifest::Type type,
69 const std::set<std::string>& permissions_set) { 69 const std::set<std::string>& permissions_set) {
70 base::DictionaryValue manifest; 70 base::DictionaryValue manifest;
71 manifest.SetString("name", std::string("Test extension ") + id); 71 manifest.SetString("name", std::string("Test extension ") + id);
72 manifest.SetString("version", "1.0"); 72 manifest.SetString("version", "1.0");
73 73
74 std::unique_ptr<base::ListValue> permissions(new base::ListValue()); 74 std::unique_ptr<base::ListValue> permissions(new base::ListValue());
75 for (std::set<std::string>::const_iterator it = permissions_set.begin(); 75 for (std::set<std::string>::const_iterator it = permissions_set.begin();
76 it != permissions_set.end(); ++it) { 76 it != permissions_set.end(); ++it) {
77 permissions->Append(new base::StringValue(*it)); 77 permissions->AppendString(*it);
78 } 78 }
79 manifest.Set("permissions", permissions.release()); 79 manifest.Set("permissions", permissions.release());
80 80
81 switch (type) { 81 switch (type) {
82 case Manifest::TYPE_EXTENSION: 82 case Manifest::TYPE_EXTENSION:
83 break; 83 break;
84 84
85 case Manifest::TYPE_LEGACY_PACKAGED_APP: { 85 case Manifest::TYPE_LEGACY_PACKAGED_APP: {
86 base::DictionaryValue* app = new base::DictionaryValue(); 86 base::DictionaryValue* app = new base::DictionaryValue();
87 base::DictionaryValue* app_launch = new base::DictionaryValue(); 87 base::DictionaryValue* app_launch = new base::DictionaryValue();
(...skipping 26 matching lines...) Expand all
114 it != permissions_set.end(); ++it) { 114 it != permissions_set.end(); ++it) {
115 DCHECK(extension->permissions_data()->HasAPIPermission(*it)); 115 DCHECK(extension->permissions_data()->HasAPIPermission(*it));
116 } 116 }
117 117
118 return extension; 118 return extension;
119 } 119 }
120 120
121 } // namespace settings_test_util 121 } // namespace settings_test_util
122 122
123 } // namespace extensions 123 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/api/management/management_api.cc ('k') | extensions/browser/api/storage/storage_frontend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698