Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: extensions/browser/api/management/management_api.cc

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/management/management_api.cc
diff --git a/extensions/browser/api/management/management_api.cc b/extensions/browser/api/management/management_api.cc
index fc043c0a0cc88bc1a51e920661d85ad203a9a8c2..d2326b5e5e4b2ae173b03e78e74aeb7f10b16219 100644
--- a/extensions/browser/api/management/management_api.cc
+++ b/extensions/browser/api/management/management_api.cc
@@ -865,7 +865,7 @@ void ManagementEventRouter::BroadcastEvent(
return; // Don't dispatch events for built-in extenions.
std::unique_ptr<base::ListValue> args(new base::ListValue());
if (event_name == management::OnUninstalled::kEventName) {
- args->Append(new base::StringValue(extension->id()));
+ args->AppendString(extension->id());
} else {
args->Append(CreateExtensionInfo(*extension, browser_context_).ToValue());
}

Powered by Google App Engine
This is Rietveld 408576698