Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: extensions/browser/quota_service_unittest.cc

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_prefs.cc ('k') | extensions/common/extension_set_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/quota_service_unittest.cc
diff --git a/extensions/browser/quota_service_unittest.cc b/extensions/browser/quota_service_unittest.cc
index dd73849be113dcf7c99919901da76a34cd72f74f..70a9346e38448248b60d2f470f5e0ea711b8e3ab 100644
--- a/extensions/browser/quota_service_unittest.cc
+++ b/extensions/browser/quota_service_unittest.cc
@@ -180,14 +180,14 @@ TEST_F(QuotaServiceTest, NoHeuristic) {
TEST_F(QuotaServiceTest, FrozenHeuristic) {
scoped_refptr<MockFunction> f(new FrozenMockFunction("foo"));
base::ListValue args;
- args.Append(new base::FundamentalValue(1));
+ args.AppendInteger(1);
EXPECT_NE("", service_->Assess(extension_a_, f.get(), &args, kStartTime));
}
TEST_F(QuotaServiceTest, SingleHeuristic) {
scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo"));
base::ListValue args;
- args.Append(new base::FundamentalValue(1));
+ args.AppendInteger(1);
EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &args, kStartTime));
EXPECT_EQ("",
service_->Assess(extension_a_,
@@ -201,8 +201,8 @@ TEST_F(QuotaServiceTest, SingleHeuristic) {
kStartTime + TimeDelta::FromSeconds(15)));
base::ListValue args2;
- args2.Append(new base::FundamentalValue(1));
- args2.Append(new base::FundamentalValue(2));
+ args2.AppendInteger(1);
+ args2.AppendInteger(2);
EXPECT_EQ("", service_->Assess(extension_b_, f.get(), &args2, kStartTime));
EXPECT_EQ("",
service_->Assess(extension_b_,
@@ -226,7 +226,7 @@ TEST_F(QuotaServiceTest, SingleHeuristic) {
// Test that items are independent.
base::ListValue args3;
- args3.Append(new base::FundamentalValue(3));
+ args3.AppendInteger(3);
EXPECT_EQ("", service_->Assess(extension_c_, f.get(), &args, kStartTime));
EXPECT_EQ("",
service_->Assess(extension_c_,
@@ -261,8 +261,8 @@ TEST_F(QuotaServiceTest, MultipleFunctionsDontInterfere) {
base::ListValue args_f;
base::ListValue args_g;
- args_f.Append(new base::FundamentalValue(1));
- args_g.Append(new base::FundamentalValue(2));
+ args_f.AppendInteger(1);
+ args_g.AppendInteger(2);
EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &args_f, kStartTime));
EXPECT_EQ("", service_->Assess(extension_a_, g.get(), &args_g, kStartTime));
@@ -291,7 +291,7 @@ TEST_F(QuotaServiceTest, MultipleFunctionsDontInterfere) {
TEST_F(QuotaServiceTest, ViolatorsWillBeForgiven) {
scoped_refptr<MockFunction> f(new TimedLimitMockFunction("foo"));
base::ListValue arg;
- arg.Append(new base::FundamentalValue(1));
+ arg.AppendInteger(1);
EXPECT_EQ("", service_->Assess(extension_a_, f.get(), &arg, kStartTime));
EXPECT_EQ("",
service_->Assess(extension_a_,
« no previous file with comments | « extensions/browser/extension_prefs.cc ('k') | extensions/common/extension_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698