Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/common/permissions/api_permission_set_unittest.cc

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_handlers/oauth2_manifest_unittest.cc ('k') | extensions/common/value_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/api_permission_set_unittest.cc
diff --git a/extensions/common/permissions/api_permission_set_unittest.cc b/extensions/common/permissions/api_permission_set_unittest.cc
index b0acc83b141f0ce394de114300c1fd5d336f51ad..4101574473e3c036befcfe6e8e8942a25df2ea46 100644
--- a/extensions/common/permissions/api_permission_set_unittest.cc
+++ b/extensions/common/permissions/api_permission_set_unittest.cc
@@ -45,9 +45,9 @@ TEST(APIPermissionSetTest, CreateUnion) {
permission = permission_info->CreateAPIPermission();
{
std::unique_ptr<base::ListValue> value(new base::ListValue());
- value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
- value->Append(new base::StringValue("udp-bind::8080"));
- value->Append(new base::StringValue("udp-send-to::8888"));
+ value->AppendString("tcp-connect:*.example.com:80");
+ value->AppendString("udp-bind::8080");
+ value->AppendString("udp-send-to::8888");
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
@@ -80,8 +80,8 @@ TEST(APIPermissionSetTest, CreateUnion) {
permission = permission_info->CreateAPIPermission();
{
std::unique_ptr<base::ListValue> value(new base::ListValue());
- value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
- value->Append(new base::StringValue("udp-send-to::8899"));
+ value->AppendString("tcp-connect:*.example.com:80");
+ value->AppendString("udp-send-to::8899");
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis2.insert(permission);
@@ -94,10 +94,10 @@ TEST(APIPermissionSetTest, CreateUnion) {
permission = permission_info->CreateAPIPermission();
{
std::unique_ptr<base::ListValue> value(new base::ListValue());
- value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
- value->Append(new base::StringValue("udp-bind::8080"));
- value->Append(new base::StringValue("udp-send-to::8888"));
- value->Append(new base::StringValue("udp-send-to::8899"));
+ value->AppendString("tcp-connect:*.example.com:80");
+ value->AppendString("udp-bind::8080");
+ value->AppendString("udp-send-to::8888");
+ value->AppendString("udp-send-to::8899");
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
// Insert a new socket permission which will replace the old one.
@@ -132,9 +132,9 @@ TEST(APIPermissionSetTest, CreateIntersection) {
permission = permission_info->CreateAPIPermission();
{
std::unique_ptr<base::ListValue> value(new base::ListValue());
- value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
- value->Append(new base::StringValue("udp-bind::8080"));
- value->Append(new base::StringValue("udp-send-to::8888"));
+ value->AppendString("tcp-connect:*.example.com:80");
+ value->AppendString("udp-bind::8080");
+ value->AppendString("udp-send-to::8888");
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis1.insert(permission);
@@ -160,9 +160,9 @@ TEST(APIPermissionSetTest, CreateIntersection) {
permission = permission_info->CreateAPIPermission();
{
std::unique_ptr<base::ListValue> value(new base::ListValue());
- value->Append(new base::StringValue("udp-bind::8080"));
- value->Append(new base::StringValue("udp-send-to::8888"));
- value->Append(new base::StringValue("udp-send-to::8899"));
+ value->AppendString("udp-bind::8080");
+ value->AppendString("udp-send-to::8888");
+ value->AppendString("udp-send-to::8899");
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis2.insert(permission);
@@ -171,8 +171,8 @@ TEST(APIPermissionSetTest, CreateIntersection) {
permission = permission_info->CreateAPIPermission();
{
std::unique_ptr<base::ListValue> value(new base::ListValue());
- value->Append(new base::StringValue("udp-bind::8080"));
- value->Append(new base::StringValue("udp-send-to::8888"));
+ value->AppendString("udp-bind::8080");
+ value->AppendString("udp-send-to::8888");
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
expected_apis.insert(permission);
@@ -206,9 +206,9 @@ TEST(APIPermissionSetTest, CreateDifference) {
permission = permission_info->CreateAPIPermission();
{
std::unique_ptr<base::ListValue> value(new base::ListValue());
- value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
- value->Append(new base::StringValue("udp-bind::8080"));
- value->Append(new base::StringValue("udp-send-to::8888"));
+ value->AppendString("tcp-connect:*.example.com:80");
+ value->AppendString("udp-bind::8080");
+ value->AppendString("udp-send-to::8888");
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis1.insert(permission);
@@ -226,8 +226,8 @@ TEST(APIPermissionSetTest, CreateDifference) {
permission = permission_info->CreateAPIPermission();
{
std::unique_ptr<base::ListValue> value(new base::ListValue());
- value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
- value->Append(new base::StringValue("udp-send-to::8899"));
+ value->AppendString("tcp-connect:*.example.com:80");
+ value->AppendString("udp-send-to::8899");
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis2.insert(permission);
@@ -236,8 +236,8 @@ TEST(APIPermissionSetTest, CreateDifference) {
permission = permission_info->CreateAPIPermission();
{
std::unique_ptr<base::ListValue> value(new base::ListValue());
- value->Append(new base::StringValue("udp-bind::8080"));
- value->Append(new base::StringValue("udp-send-to::8888"));
+ value->AppendString("udp-bind::8080");
+ value->AppendString("udp-send-to::8888");
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
expected_apis.insert(permission);
@@ -269,9 +269,9 @@ TEST(APIPermissionSetTest, IPC) {
permission = permission_info->CreateAPIPermission();
{
std::unique_ptr<base::ListValue> value(new base::ListValue());
- value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
- value->Append(new base::StringValue("udp-bind::8080"));
- value->Append(new base::StringValue("udp-send-to::8888"));
+ value->AppendString("tcp-connect:*.example.com:80");
+ value->AppendString("udp-bind::8080");
+ value->AppendString("udp-send-to::8888");
ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));
}
apis.insert(permission);
« no previous file with comments | « extensions/common/manifest_handlers/oauth2_manifest_unittest.cc ('k') | extensions/common/value_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698