extensions/common/file_util_unittest.cc - Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/file_util_unittest.cc

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/features/simple_feature_unittest.cc ('k') | extensions/common/manifest_handlers/oauth2_manifest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/file_util_unittest.cc

diff --git a/extensions/common/file_util_unittest.cc b/extensions/common/file_util_unittest.cc

index 62be7d2196cfec8f4a3870edce878f921ba44af4..41cd4de99651ab890493d15495fcc568be9888dc 100644

--- a/extensions/common/file_util_unittest.cc

+++ b/extensions/common/file_util_unittest.cc

@@ -290,7 +290,7 @@ TEST_F(FileUtilTest, BackgroundScriptsMustExist) {

value->SetInteger("manifest_version", 1);

base::ListValue* scripts = new base::ListValue();

- scripts->Append(new base::StringValue("foo.js"));

+ scripts->AppendString("foo.js");

value->Set("background.scripts", scripts);

std::string error;

@@ -308,7 +308,7 @@ TEST_F(FileUtilTest, BackgroundScriptsMustExist) {

EXPECT_EQ(0U, warnings.size());

scripts->Clear();

- scripts->Append(new base::StringValue("http://google.com/foo.js"));

+ scripts->AppendString("http://google.com/foo.js");

extension = LoadExtensionManifest(*value.get(), temp.path(),

Manifest::UNPACKED, 0, &error);