extensions/browser/api/web_request/upload_data_presenter_unittest.cc - Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/upload_data_presenter_unittest.cc

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/web_request/upload_data_presenter.cc ('k') | extensions/browser/api/web_request/web_request_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_request/upload_data_presenter_unittest.cc

diff --git a/extensions/browser/api/web_request/upload_data_presenter_unittest.cc b/extensions/browser/api/web_request/upload_data_presenter_unittest.cc

index 50b648680caa0079166cd32d3af77de67938fb74..ff27ebcc6f744fc830faf765ccf4cba57a066300 100644

--- a/extensions/browser/api/web_request/upload_data_presenter_unittest.cc

+++ b/extensions/browser/api/web_request/upload_data_presenter_unittest.cc

@@ -24,7 +24,7 @@ TEST(WebRequestUploadDataPresenterTest, ParsedData) {

// Expected output.

std::unique_ptr<base::ListValue> values(new base::ListValue);

- values->Append(new base::StringValue("value"));

+ values->AppendString("value");

base::DictionaryValue expected_form;

expected_form.SetWithoutPathExpansion("key.with.dots", values.release());