Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: extensions/browser/api/storage/settings_test_util.cc

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/storage/settings_test_util.cc
diff --git a/extensions/browser/api/storage/settings_test_util.cc b/extensions/browser/api/storage/settings_test_util.cc
index 0521d235d95c8082863c6a3c8cd2960865ed83e4..1a363fabfe778d054f0d9b6ba1ca3d8d8236985a 100644
--- a/extensions/browser/api/storage/settings_test_util.cc
+++ b/extensions/browser/api/storage/settings_test_util.cc
@@ -74,7 +74,7 @@ scoped_refptr<const Extension> AddExtensionWithIdAndPermissions(
std::unique_ptr<base::ListValue> permissions(new base::ListValue());
for (std::set<std::string>::const_iterator it = permissions_set.begin();
it != permissions_set.end(); ++it) {
- permissions->Append(new base::StringValue(*it));
+ permissions->AppendString(*it);
}
manifest.Set("permissions", permissions.release());
« no previous file with comments | « extensions/browser/api/management/management_api.cc ('k') | extensions/browser/api/storage/storage_frontend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698