Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: extensions/common/manifest_handlers/oauth2_manifest_unittest.cc

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handlers/oauth2_manifest_unittest.cc
diff --git a/extensions/common/manifest_handlers/oauth2_manifest_unittest.cc b/extensions/common/manifest_handlers/oauth2_manifest_unittest.cc
index aaafc62027acf705ad8815f3796ee0936fac3099..34acffdd279bc11099aa1593ac819c4ec0a8b8e6 100644
--- a/extensions/common/manifest_handlers/oauth2_manifest_unittest.cc
+++ b/extensions/common/manifest_handlers/oauth2_manifest_unittest.cc
@@ -94,8 +94,8 @@ TEST_F(OAuth2ManifestTest, OAuth2SectionParsing) {
base_manifest.SetInteger(keys::kManifestVersion, 2);
base_manifest.SetString(keys::kOAuth2ClientId, "client1");
base::ListValue* scopes = new base::ListValue();
- scopes->Append(new base::StringValue("scope1"));
- scopes->Append(new base::StringValue("scope2"));
+ scopes->AppendString("scope1");
+ scopes->AppendString("scope2");
base_manifest.Set(keys::kOAuth2Scopes, scopes);
// OAuth2 section should be parsed for an extension.
« no previous file with comments | « extensions/common/file_util_unittest.cc ('k') | extensions/common/permissions/api_permission_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698