Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions

extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 31 matching lines @@
 }
 
 TEST(WebRequestConditionAttributeTest, CreateConditionAttribute) {
   // Necessary for TestURLRequest.
   base::MessageLoopForIO message_loop;
 
   std::string error;
   scoped_refptr<const WebRequestConditionAttribute> result;
   base::StringValue string_value("main_frame");
   base::ListValue resource_types;
-  resource_types.Append(new base::StringValue("main_frame"));
+  resource_types.AppendString("main_frame");
 
   // Test wrong condition name passed.
   error.clear();
   result = WebRequestConditionAttribute::Create(
       kUnknownConditionName, &resource_types, &error);
   EXPECT_FALSE(error.empty());
   EXPECT_FALSE(result.get());
 
   // Test wrong data type passed
   error.clear();
@@ skipping 20 matching lines @@
 }
 
 TEST(WebRequestConditionAttributeTest, ResourceType) {
   // Necessary for TestURLRequest.
   base::MessageLoopForIO message_loop;
 
   std::string error;
   base::ListValue resource_types;
   // The 'sub_frame' value is chosen arbitrarily, so as the corresponding
   // content::ResourceType is not 0, the default value.
-  resource_types.Append(new base::StringValue("sub_frame"));
+  resource_types.AppendString("sub_frame");
 
   scoped_refptr<const WebRequestConditionAttribute> attribute =
       WebRequestConditionAttribute::Create(
           keys::kResourceTypeKey, &resource_types, &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(attribute.get());
   EXPECT_EQ(std::string(keys::kResourceTypeKey), attribute->GetName());
 
   net::TestURLRequestContext context;
   std::unique_ptr<net::URLRequest> url_request_ok(context.CreateRequest(
@@ skipping 42 matching lines @@
   ASSERT_TRUE(test_server.Start());
 
   net::TestURLRequestContext context;
   net::TestDelegate delegate;
   std::unique_ptr<net::URLRequest> url_request(context.CreateRequest(
       test_server.GetURL("/headers.html"), net::DEFAULT_PRIORITY, &delegate));
   url_request->Start();
   base::MessageLoop::current()->Run();
 
   base::ListValue content_types;
-  content_types.Append(new base::StringValue("text/plain"));
+  content_types.AppendString("text/plain");
   scoped_refptr<const WebRequestConditionAttribute> attribute_include =
       WebRequestConditionAttribute::Create(
           keys::kContentTypeKey, &content_types, &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(attribute_include.get());
   EXPECT_FALSE(attribute_include->IsFulfilled(
       WebRequestData(url_request.get(), ON_BEFORE_REQUEST,
                      url_request->response_headers())));
   EXPECT_TRUE(attribute_include->IsFulfilled(
       WebRequestData(url_request.get(), ON_HEADERS_RECEIVED,
                      url_request->response_headers())));
   EXPECT_EQ(std::string(keys::kContentTypeKey), attribute_include->GetName());
 
   scoped_refptr<const WebRequestConditionAttribute> attribute_exclude =
       WebRequestConditionAttribute::Create(
           keys::kExcludeContentTypeKey, &content_types, &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(attribute_exclude.get());
   EXPECT_FALSE(attribute_exclude->IsFulfilled(
       WebRequestData(url_request.get(), ON_HEADERS_RECEIVED,
                      url_request->response_headers())));
 
   content_types.Clear();
-  content_types.Append(new base::StringValue("something/invalid"));
+  content_types.AppendString("something/invalid");
   scoped_refptr<const WebRequestConditionAttribute> attribute_unincluded =
       WebRequestConditionAttribute::Create(
           keys::kContentTypeKey, &content_types, &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(attribute_unincluded.get());
   EXPECT_FALSE(attribute_unincluded->IsFulfilled(
       WebRequestData(url_request.get(), ON_HEADERS_RECEIVED,
                      url_request->response_headers())));
 
   scoped_refptr<const WebRequestConditionAttribute> attribute_unexcluded =
@@ skipping 191 matching lines @@
       base::ListValue* list = NULL;
       if (!dictionary->GetWithoutPathExpansion(*name, &entry))
         return std::unique_ptr<base::DictionaryValue>();
       switch (entry->GetType()) {
         case base::Value::TYPE_STRING:
           // Replace the present string with a list.
           list = new base::ListValue;
           // Ignoring return value, we already verified the entry is there.
           dictionary->RemoveWithoutPathExpansion(*name, &entry_owned);
           list->Append(entry_owned.release());
-          list->Append(new base::StringValue(*value));
+          list->AppendString(*value);
           dictionary->SetWithoutPathExpansion(*name, list);
           break;
         case base::Value::TYPE_LIST:  // Just append to the list.
           CHECK(entry->GetAsList(&list));
-          list->Append(new base::StringValue(*value));
+          list->AppendString(*value);
           break;
         default:
           NOTREACHED();  // We never put other Values here.
           return std::unique_ptr<base::DictionaryValue>();
       }
     } else {
       dictionary->SetString(*name, *value);
     }
   }
   return dictionary;
@@ skipping 304 matching lines @@
   };
   const size_t kExistingSize[] = { arraysize(kExisting) };
   GetArrayAsVector(kExisting, kExistingSize, 1u, &tests);
   MatchAndCheck(tests, keys::kExcludeResponseHeadersKey, stage,
                 url_request.get(), &result);
   EXPECT_FALSE(result);
 }
 
 }  // namespace
 }  // namespace extensions