Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: extensions/browser/extension_prefs.cc

Issue 2037703004: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/event_router.cc ('k') | extensions/browser/quota_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_prefs.cc
diff --git a/extensions/browser/extension_prefs.cc b/extensions/browser/extension_prefs.cc
index 5e77c0c250c2e13f7f7190e84cc09d9731715ec3..13820316ec9cb0badd3b6f172043b0c5ad92ad17 100644
--- a/extensions/browser/extension_prefs.cc
+++ b/extensions/browser/extension_prefs.cc
@@ -632,7 +632,7 @@ static base::ListValue* CreatePermissionList(const T& permissions) {
tmp->Set(i->name(), detail.release());
values->Append(tmp);
} else {
- values->Append(new base::StringValue(i->name()));
+ values->AppendString(i->name());
}
}
return values;
@@ -1838,7 +1838,7 @@ void ExtensionPrefs::SetExtensionPrefFromContainer(
list_of_values->Clear();
for (typename ExtensionIdContainer::const_iterator iter = strings.begin();
iter != strings.end(); ++iter) {
- list_of_values->Append(new base::StringValue(*iter));
+ list_of_values->AppendString(*iter);
}
}
« no previous file with comments | « extensions/browser/event_router.cc ('k') | extensions/browser/quota_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698