[DevTools] Move Console to v8 inspector.

[DevTools] Move Console to v8 inspector.

This patch moves Console domain, console message, storage and console agent to v8 inspector.

Possible follow-ups:
- removing ConsoleMessage from blink;
- migrating from V8StackTrace to V8SourceLocation;
- removing FrameConsole abstraction;
- exposing single entry method for adding message with parameters.

BUG=613882
TBR=pfeldman@chromium.org (for includes)

Committed: https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d
Cr-Commit-Position: refs/heads/master@{#403006}

[dgozman, 2016-06-16 07:28:22]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 07:28:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035653006/100001

[commit-bot: I haz the power, 2016-06-16 08:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 08:58:35]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-06-18 04:54:22]

Description was changed from

==========
[DevTools] Move Console to v8 inspector.

BUG=613882
==========

to

==========
[DevTools] Move Console to v8 inspector.

This patch moves Console domain, console message and storage and console agent
to v8 inspector.

Possible follow-ups:
- removing ConsoleMessage from blink;
- migrating from V8StackTrace to V8SourceLocation;
- removing FrameConsole abstraction;
- exposing single entry method for adding message with parameters.

BUG=613882
==========

[dgozman, 2016-06-18 04:54:33]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[dgozman, 2016-06-18 04:54:34]

Aleksei, could you please take a look? I will do some cleanup, but everything
else is here.

[pfeldman, 2016-06-18 10:45:40]

will we follow up with brushing it up and moving v8initializer error messages
into runtime?

[dgozman, 2016-06-18 19:12:50]

On 2016/06/18 10:45:40, pfeldman_slow wrote:
> will we follow up with brushing it up and moving v8initializer error messages
> into runtime?

I will definitely investigate the possibility.

[dgozman, 2016-06-18 19:13:41]

Description was changed from

==========
[DevTools] Move Console to v8 inspector.

This patch moves Console domain, console message and storage and console agent
to v8 inspector.

Possible follow-ups:
- removing ConsoleMessage from blink;
- migrating from V8StackTrace to V8SourceLocation;
- removing FrameConsole abstraction;
- exposing single entry method for adding message with parameters.

BUG=613882
==========

to

==========
[DevTools] Move Console to v8 inspector.

This patch moves Console domain, console message, storage and console agent to
v8 inspector.

Possible follow-ups:
- removing ConsoleMessage from blink;
- migrating from V8StackTrace to V8SourceLocation;
- removing FrameConsole abstraction;
- exposing single entry method for adding message with parameters.

BUG=613882
==========

[kozy, 2016-06-23 22:28:44]

lgtm

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/ScriptArguments.h (left):

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ScriptArguments.h:1: /*
Please remove .cpp too!

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp (right):

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp:86:
std::unique_ptr<V8ConsoleMessage> consoleMessage = nullptr;
Maybe refactoring it?
        protocol::Vector<v8::Local<v8::Value>> messageArguments;
        if (arguments) {
            for (int i = skipArgumentCount; i < arguments->Length(); ++i)
                messageArguments.append((*arguments)[i]);
        }
        std::unique_ptr<V8ConsoleMessage> consoleMessage =
V8ConsoleMessage::createForConsoleAPI(debugger->client()->currentTimeMS(), type,
level, message, &messageArguments, debugger->captureStackTrace(false),
inspectedContext);

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
(right):

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp:322: if
(arguments) {
&& arguments.size()

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp:329:
std::unique_ptr<V8ConsoleMessage> message = wrapUnique(new
V8ConsoleMessage(timestampMS, ConsoleAPIMessageSource, level, actualMessage,
url, lineNumber, columnNumber, std::move(stackTrace), 0, String16()));
0 /* scriptId */, String16() /* requestIdentifier */

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp:379: 
style: extra blank line

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:187:
debugger->client()->muteWarningsAndDeprecations();
TODO:remove mute warnings and deprecations

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:807: "name":
"messageRepeatCountUpdated",
Please remove it in follow up.

[dgozman, 2016-06-28 01:43:48]

All done.

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/ScriptArguments.h (left):

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ScriptArguments.h:1: /*
On 2016/06/23 22:28:43, kozyatinskiy wrote:
> Please remove .cpp too!

Done.

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp (right):

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp:86:
std::unique_ptr<V8ConsoleMessage> consoleMessage = nullptr;
On 2016/06/23 22:28:43, kozyatinskiy wrote:
> Maybe refactoring it?
>         protocol::Vector<v8::Local<v8::Value>> messageArguments;
>         if (arguments) {
>             for (int i = skipArgumentCount; i < arguments->Length(); ++i)
>                 messageArguments.append((*arguments)[i]);
>         }
>         std::unique_ptr<V8ConsoleMessage> consoleMessage =
> V8ConsoleMessage::createForConsoleAPI(debugger->client()->currentTimeMS(),
type,
> level, message, &messageArguments, debugger->captureStackTrace(false),
> inspectedContext);

I prefer to pass nullptr when there are not arguments.

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
(right):

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp:322: if
(arguments) {
On 2016/06/23 22:28:43, kozyatinskiy wrote:
> && arguments.size()

Done.

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp:329:
std::unique_ptr<V8ConsoleMessage> message = wrapUnique(new
V8ConsoleMessage(timestampMS, ConsoleAPIMessageSource, level, actualMessage,
url, lineNumber, columnNumber, std::move(stackTrace), 0, String16()));
On 2016/06/23 22:28:43, kozyatinskiy wrote:
> 0 /* scriptId */, String16() /* requestIdentifier */

Done.

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp:379: 
On 2016/06/23 22:28:43, kozyatinskiy wrote:
> style: extra blank line

Done.

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/2035653006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:187:
debugger->client()->muteWarningsAndDeprecations();
On 2016/06/23 22:28:44, kozyatinskiy wrote:
> TODO:remove mute warnings and deprecations

Done.

[dgozman, 2016-06-28 01:43:56]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 01:44:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-06-28 01:48:13]

dgozman@chromium.org changed reviewers:
+ jochen@chromium.org, pfeldman@chromium.org

[dgozman, 2016-06-28 01:48:14]

Could you please take a look?

Jochen - at bindings/
Pavel - at v8_inspector/public/

Thanks,
Dmitry

[commit-bot: I haz the power, 2016-06-28 03:19:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 03:19:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jochen (gone - plz use gerrit), 2016-06-28 13:12:19]

bindings lgtm

[dgozman, 2016-06-28 23:17:31]

Description was changed from

==========
[DevTools] Move Console to v8 inspector.

This patch moves Console domain, console message, storage and console agent to
v8 inspector.

Possible follow-ups:
- removing ConsoleMessage from blink;
- migrating from V8StackTrace to V8SourceLocation;
- removing FrameConsole abstraction;
- exposing single entry method for adding message with parameters.

BUG=613882
==========

to

==========
[DevTools] Move Console to v8 inspector.

This patch moves Console domain, console message, storage and console agent to
v8 inspector.

Possible follow-ups:
- removing ConsoleMessage from blink;
- migrating from V8StackTrace to V8SourceLocation;
- removing FrameConsole abstraction;
- exposing single entry method for adding message with parameters.

BUG=613882
TBR=pfeldman@chromium.org (for includes)
==========

[dgozman, 2016-06-28 23:18:04]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-06-28 23:18:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2035653006/#ps140001
(title: "fixed review comments")

[commit-bot: I haz the power, 2016-06-28 23:19:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 23:39:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 23:39:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2016-06-29 20:50:13]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 20:51:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 22:16:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 22:16:30]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2016-06-29 22:31:44]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-06-29 22:31:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2035653006/#ps160001
(title: "improved api a bit")

[commit-bot: I haz the power, 2016-06-29 22:34:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:09:55]

Description was changed from

==========
[DevTools] Move Console to v8 inspector.

This patch moves Console domain, console message, storage and console agent to
v8 inspector.

Possible follow-ups:
- removing ConsoleMessage from blink;
- migrating from V8StackTrace to V8SourceLocation;
- removing FrameConsole abstraction;
- exposing single entry method for adding message with parameters.

BUG=613882
TBR=pfeldman@chromium.org (for includes)
==========

to

==========
[DevTools] Move Console to v8 inspector.

This patch moves Console domain, console message, storage and console agent to
v8 inspector.

Possible follow-ups:
- removing ConsoleMessage from blink;
- migrating from V8StackTrace to V8SourceLocation;
- removing FrameConsole abstraction;
- exposing single entry method for adding message with parameters.

BUG=613882
TBR=pfeldman@chromium.org (for includes)
==========

[commit-bot: I haz the power, 2016-06-30 00:09:57]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-06-30 00:10:05]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 00:13:57]

Description was changed from

==========
[DevTools] Move Console to v8 inspector.

This patch moves Console domain, console message, storage and console agent to
v8 inspector.

Possible follow-ups:
- removing ConsoleMessage from blink;
- migrating from V8StackTrace to V8SourceLocation;
- removing FrameConsole abstraction;
- exposing single entry method for adding message with parameters.

BUG=613882
TBR=pfeldman@chromium.org (for includes)
==========

to

==========
[DevTools] Move Console to v8 inspector.

This patch moves Console domain, console message, storage and console agent to
v8 inspector.

Possible follow-ups:
- removing ConsoleMessage from blink;
- migrating from V8StackTrace to V8SourceLocation;
- removing FrameConsole abstraction;
- exposing single entry method for adding message with parameters.

BUG=613882
TBR=pfeldman@chromium.org (for includes)

Committed: https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d
Cr-Commit-Position: refs/heads/master@{#403006}
==========

[commit-bot: I haz the power, 2016-06-30 00:14:00]

Patchset 9 (id:??) landed as
https://crrev.com/2bee43695b522e74827332cf43ca2d87ebe32a7d
Cr-Commit-Position: refs/heads/master@{#403006}