third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp - Issue 2035653006: [DevTools] Move Console to v8 inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improved api a bit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

index f6573e38431fe5c1f24825e2a4c473edb2563d4e..97612d744962a6384bc73ad43d83d9bb1344add0 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

@@ -62,7 +62,7 @@

#include "core/frame/VisualViewport.h"

#include "core/html/HTMLFrameOwnerElement.h"

#include "core/input/EventHandler.h"

-#include "core/inspector/ConsoleMessageStorage.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/InspectorInstrumentation.h"

#include "core/loader/DocumentLoader.h"

#include "core/loader/FrameLoaderClient.h"

@@ -498,7 +498,6 @@ MediaQueryList* LocalDOMWindow::matchMedia(const String& media)

void LocalDOMWindow::willDetachFrameHost()

{

frame()->host()->eventHandlerRegistry().didRemoveAllEventHandlers(*this);

- frame()->host()->consoleMessageStorage().frameWindowDiscarded(this);

LocalDOMWindow::notifyContextDestroyed();

}