Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: improved api a bit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
index 1cfaa78de8109a62c1cfafa3fee05d2610633ac8..5ac5e66b400b36380fa3546aa8691724697479ec 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
@@ -5,10 +5,13 @@
#ifndef V8Debugger_h
#define V8Debugger_h
+#include "platform/inspector_protocol/Collections.h"
#include "platform/inspector_protocol/Platform.h"
#include "platform/inspector_protocol/String16.h"
+#include "platform/v8_inspector/public/V8ConsoleTypes.h"
#include <v8.h>
+#include <vector>
namespace blink {
@@ -28,9 +31,6 @@ public:
static std::unique_ptr<V8Debugger> create(v8::Isolate*, V8DebuggerClient*);
virtual ~V8Debugger() { }
- // TODO(dgozman): make this non-static?
- static int contextId(v8::Local<v8::Context>);
-
virtual void contextCreated(const V8ContextInfo&) = 0;
virtual void contextDestroyed(v8::Local<v8::Context>) = 0;
// TODO(dgozman): remove this one.
@@ -39,12 +39,22 @@ public:
virtual void didExecuteScript(v8::Local<v8::Context>) = 0;
virtual void idleStarted() = 0;
virtual void idleFinished() = 0;
+ // TODO(dgozman): remove requestIdentifier.
+ virtual bool addConsoleMessage(int contextGroupId, MessageSource, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId, const String16& requestIdentifier) = 0;
+ // TODO(dgozman): can we remove this method?
+ virtual void logToConsole(v8::Local<v8::Context>, const String16& message, v8::Local<v8::Value> arg1, v8::Local<v8::Value> arg2) = 0;
+ virtual unsigned promiseRejected(v8::Local<v8::Context>, const String16& errorMessage, v8::Local<v8::Value> reason, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId) = 0;
+ virtual void promiseRejectionRevoked(v8::Local<v8::Context>, unsigned promiseRejectionId) = 0;
+ virtual void consoleMessagesCount(int contextGroupId, unsigned* total, unsigned* withArguments) = 0;
+ // TODO(dgozman): remove mute methods.
+ virtual void muteConsole() = 0;
+ virtual void unmuteConsole() = 0;
virtual std::unique_ptr<V8InspectorSession> connect(int contextGroupId, protocol::FrontendChannel*, V8InspectorSessionClient*, const String16* state) = 0;
virtual bool isPaused() = 0;
virtual std::unique_ptr<V8StackTrace> createStackTrace(v8::Local<v8::StackTrace>) = 0;
- virtual std::unique_ptr<V8StackTrace> captureStackTrace(size_t maxStackSize) = 0;
+ virtual std::unique_ptr<V8StackTrace> captureStackTrace(bool fullStack) = 0;
// API to report async call stacks.
virtual void asyncTaskScheduled(const String16& taskName, void* task, bool recurring) = 0;

Powered by Google App Engine
This is Rietveld 408576698