third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h - Issue 2035653006: [DevTools] Move Console to v8 inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improved api a bit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h ('k') | third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

index 6d5c4804c4be35c2400d13dbb2b29a29557b3652..beee1155f6e87f547e404d5617684b0563feb991 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

@@ -13,19 +13,9 @@

namespace blink {

-class TracedValue;

-const v8::StackTrace::StackTraceOptions stackTraceOptions = static_cast<v8::StackTrace::StackTraceOptions>(

- v8::StackTrace::kLineNumber |

- v8::StackTrace::kColumnOffset |

- v8::StackTrace::kScriptId |

- v8::StackTrace::kScriptNameOrSourceURL |

- v8::StackTrace::kFunctionName);

+// TODO(dgozman): migrate to V8SourceLocation.

class V8StackTrace {

public:

- static const size_t maxCallStackSizeToCapture = 200;

virtual bool isEmpty() const = 0;

virtual String16 topSourceURL() const = 0;

virtual int topLineNumber() const = 0;