Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: improved api a bit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
index 36f5cb6dd8813badb26867ce9596af60e3b6d728..e38f019ece1127cc7276ec65340053fd15f81306 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
@@ -43,11 +43,11 @@
#include "core/fetch/UniqueIdentifier.h"
#include "core/fileapi/FileReaderLoader.h"
#include "core/fileapi/FileReaderLoaderClient.h"
+#include "core/frame/FrameConsole.h"
#include "core/frame/FrameHost.h"
#include "core/frame/LocalFrame.h"
#include "core/html/HTMLFrameOwnerElement.h"
#include "core/inspector/ConsoleMessage.h"
-#include "core/inspector/ConsoleMessageStorage.h"
#include "core/inspector/IdentifiersFactory.h"
#include "core/inspector/InspectedFrames.h"
#include "core/inspector/InspectorInstrumentation.h"
@@ -729,7 +729,7 @@ void InspectorNetworkAgent::didFinishXHRInternal(ExecutionContext* context, XMLH
if (m_state->booleanProperty(NetworkAgentState::monitoringXHR, false)) {
String message = (success ? "XHR finished loading: " : "XHR failed loading: ") + method + " \"" + url + "\".";
ConsoleMessage* consoleMessage = ConsoleMessage::createForRequest(NetworkMessageSource, DebugMessageLevel, message, url, it->value);
- m_inspectedFrames->root()->host()->consoleMessageStorage().reportMessage(context, consoleMessage);
+ m_inspectedFrames->root()->console().addMessageToStorage(consoleMessage);
}
m_knownRequestIdMap.remove(client);
}
@@ -755,7 +755,7 @@ void InspectorNetworkAgent::didFinishFetch(ExecutionContext* context, Threadable
if (m_state->booleanProperty(NetworkAgentState::monitoringXHR, false)) {
String message = "Fetch complete: " + method + " \"" + url + "\".";
ConsoleMessage* consoleMessage = ConsoleMessage::createForRequest(NetworkMessageSource, DebugMessageLevel, message, url, it->value);
- m_inspectedFrames->root()->host()->consoleMessageStorage().reportMessage(context, consoleMessage);
+ m_inspectedFrames->root()->console().addMessageToStorage(consoleMessage);
}
m_knownRequestIdMap.remove(client);
}

Powered by Google App Engine
This is Rietveld 408576698