third_party/WebKit/Source/core/inspector/MainThreadDebugger.h - Issue 2035653006: [DevTools] Move Console to v8 inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improved api a bit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorSession.cpp ('k') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

index 128b9480b0c0c804bf84d27c8c1a1dbf7e00e592..f2af18bb05f828cb79e3760f4a597e74fd5b5857 100644

--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

@@ -72,8 +72,7 @@ public:

void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;

v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) override;

-protected:

- void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*) override;

+ void messageAddedToConsole(int contextGroupId, MessageSource, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) override;

private:

// V8DebuggerClient implementation.

@@ -81,10 +80,8 @@ private:

void quitMessageLoopOnPause() override;

void muteWarningsAndDeprecations() override;

void unmuteWarningsAndDeprecations() override;

- void muteConsole() override;

- void unmuteConsole() override;

bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) override;

- int ensureDefaultContextInGroup(int contextGroupId) override;

+ v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) override;

std::unique_ptr<ClientMessageLoop> m_clientMessageLoop;

std::unique_ptr<InspectorTaskRunner> m_taskRunner;