Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: improved api a bit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
index 839b8c0dbea00bade9de7499a0e306e6a695dc3c..d20f8ba0ef0e7369470886c78ea4ffea62c3f814 100644
--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
@@ -48,9 +48,10 @@
#include "core/frame/Deprecation.h"
#include "core/frame/LocalDOMWindow.h"
#include "core/inspector/ConsoleMessage.h"
-#include "core/inspector/ConsoleMessageStorage.h"
-#include "core/inspector/InspectorConsoleInstrumentation.h"
+#include "core/inspector/IdentifiersFactory.h"
+#include "core/inspector/InspectorInstrumentation.h"
#include "core/inspector/WorkerInspectorController.h"
+#include "core/inspector/WorkerThreadDebugger.h"
#include "core/loader/WorkerThreadableLoader.h"
#include "core/workers/WorkerClients.h"
#include "core/workers/WorkerLoaderProxy.h"
@@ -81,7 +82,6 @@ WorkerGlobalScope::WorkerGlobalScope(const KURL& url, const String& userAgent, W
, m_workerClients(workerClients)
, m_timers(Platform::current()->currentThread()->scheduler()->timerTaskRunner()->adoptClone())
, m_timeOrigin(timeOrigin)
- , m_messageStorage(ConsoleMessageStorage::create())
{
setSecurityOrigin(SecurityOrigin::create(url));
if (starterOriginPrivilageData)
@@ -287,7 +287,20 @@ void WorkerGlobalScope::addConsoleMessage(ConsoleMessage* consoleMessage)
void WorkerGlobalScope::addMessageToWorkerConsole(ConsoleMessage* consoleMessage)
{
DCHECK(isContextThread());
- m_messageStorage->reportMessage(this, consoleMessage);
+ WorkerThreadDebugger* debugger = WorkerThreadDebugger::from(thread()->isolate());
+ if (!debugger)
+ return;
+ debugger->debugger()->addConsoleMessage(
+ debugger->contextGroupId(),
+ consoleMessage->source(),
+ consoleMessage->level(),
+ consoleMessage->message(),
+ consoleMessage->location()->url(),
+ consoleMessage->location()->lineNumber(),
+ consoleMessage->location()->columnNumber(),
+ consoleMessage->location()->cloneStackTrace(),
+ consoleMessage->location()->scriptId(),
+ IdentifiersFactory::requestId(consoleMessage->requestIdentifier()));
}
bool WorkerGlobalScope::isContextThread() const
@@ -340,11 +353,6 @@ void WorkerGlobalScope::countDeprecation(UseCounter::Feature feature) const
}
}
-ConsoleMessageStorage* WorkerGlobalScope::messageStorage()
-{
- return m_messageStorage.get();
-}
-
void WorkerGlobalScope::exceptionUnhandled(const String& errorMessage, std::unique_ptr<SourceLocation> location)
{
addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, errorMessage, std::move(location)));
@@ -397,7 +405,6 @@ DEFINE_TRACE(WorkerGlobalScope)
visitor->trace(m_eventQueue);
visitor->trace(m_workerClients);
visitor->trace(m_timers);
- visitor->trace(m_messageStorage);
visitor->trace(m_eventListeners);
ExecutionContext::trace(visitor);
EventTargetWithInlineData::trace(visitor);

Powered by Google App Engine
This is Rietveld 408576698